Compile Error in lib/err/errPosix.c: assignment to 'char *' from 'int'

[smogm]

Describe the bug

With recent gcc 14.3.0 compilation failes in here because of

The XSI-compliant version of strerror_r() is provided if:
(_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && ! _GNU_SOURCE
Otherwise, the GNU-specific version is provided.

See https://linux.die.net/man/3/strerror_r

Reproduction steps

...

Expected behavior

The variable p should be declared as int in #if defined(__linux__) and as char* in the else part.

Additional context

No response

[PaTHml]

Hi, thanks for reporting this,
Is this specific to a distro?
Regardless, which one was used to build here?
What's the configure command line looks like

Thanks

[smogm]

I'm trying to compile it with buildroot with x86_64-achtcom_x86_64-linux-musl-gcc.

The complete error message is:

errPosix.c: In function 'ErrErrno2String':
errPosix.c:67:6: error: assignment to 'char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
   67 |    p = strerror_r(errorNumber, buf, bufSize);
      |      ^
make[3]: *** [Makefile:510: errPosix.lo] Error 1
make[3]: *** Waiting for unfinished jobs....```

[PaTHml]

https://github.com/vmware/open-vm-tools/blob/master/open-vm-tools/lib/err/errPosix.c

Defines:
~line 26

#if defined __linux__
/* Force GNU strerror_r prototype instead of Posix prototype */
#  define _GNU_SOURCE
#endif

Your build environment or compiler seems to be missing something w.r.t either having 'linux' defined or respecting/supporting '_GNU_SOURCE'.

Can you fill out the details I asked earlier and add the version info for the gcc used (gcc --version) as well?
Thanks,