terra/raster conflict causing crash on transfer module

[ThomWorm]

Hello,
I'm trying out Wallace - looks great!
I've built a simple bioclim model that I'd like to transfer to a new extent - because I'm interested in species invasion.
Everything seems to work fine (I get a reasonable-looking prediction) until I use the Transfer module, which causes a crash.

The error is pasted below - it looks like Wallace is storing the environmental rasters as terra s4 objects and then tries to appy raster::cellStats()
This crash occurs with the "transfer to a new extent" and "transfer to new environments" options.
Maybe something in this module wasn't fully ported over to terra?

Warning: [crs] expected a character string, not a CRS object Warning: Error in : unable to find an inherited method for function ‘cellStats’ for signature ‘x = "SpatRaster"’ 86: stop 85: <Anonymous> 84: raster::cellStats 82: observe [/home/tworm/.cache/R/renv/cache/v5/linux-rhel-9.6/R-4.5/x86_64-redhat-linux-gnu/wallace/2.2.0/433d3f81a66d3897ead3a8b4f2235109/wallace/shiny/modules/xfer_user.R#335] 81: <observer:observeEvent(input$goTransferUser)> 2: shiny::runApp 1: run_wallace [/tmp/RtmpeoYDGT/renv-package-new-7cbc44362799/wallace/R/run_wallace.R#48] Warning: Error in if: argument is of length zero 52: xfer_user_module_map [/home/tworm/.cache/R/renv/cache/v5/linux-rhel-9.6/R-4.5/x86_64-redhat-linux-gnu/wallace/2.2.0/433d3f81a66d3897ead3a8b4f2235109/wallace/shiny/modules/xfer_user.R#421] 50: observe [/home/tworm/.cache/R/renv/cache/v5/linux-rhel-9.6/R-4.5/x86_64-redhat-linux-gnu/wallace/2.2.0/433d3f81a66d3897ead3a8b4f2235109/wallace/shiny/server.R#169] 49: <observer> 2: shiny::runApp 1: run_wallace [/tmp/RtmpeoYDGT/renv-package-new-7cbc44362799/wallace/R/run_wallace.R#48]

[ThomWorm]

in module xfer_area() I attempted a fix by switching the lines in the metadata section that used raster::cellStats() to use terra as it appeared that the issue was caused by calling cellStats on a terra object.

`
# METADATA ####

spp[[curSp()]]$rmm$data$transfer$environment1$minVal <-
  printVecAsis(terra::global(xferExt, "min", na.rm = TRUE)[[1]], asChar = TRUE)
spp[[curSp()]]$rmm$data$transfer$environment1$maxVal <-
  printVecAsis(terra::global(xferExt, "max", na.rm = TRUE)[[1]], asChar = TRUE)

  printVecAsis(terra::global(xferAreaThr, "min", na.rm = TRUE)[[1]], asChar = TRUE)
spp[[curSp()]]$rmm$prediction$transfer$environment1$maxVal <-
  printVecAsis(terra::global(xferAreaThr, "max", na.rm = TRUE)[[1]], asChar = TRUE)
`

However, it looks like I'm getting the reverse error now Warning: [crs] expected a character string, not a CRS object Warning: Error in : unable to find an inherited method for function ‘global’ for signature ‘x = "RasterBrick"’

Perhaps there are inconsistent terra/raster objects being passed?

[ThomWorm]

OK this kludgy fix to xfer_area() seems to work, by handling both kinds of objects with some custom functions.
I don't want to touch the way the devs are handling objects on the backend, so I'll hold off on a PR, but this should help anyone who gets stuck by inconsistent object typing in any of the xfer_ functions until this can get patched.

` # METADATA ####
getMin <- function(x) {
if (inherits(x, "SpatRaster")) {
terra::global(x, "min", na.rm = TRUE)[[1]]
} else {
raster::cellStats(x, min)
}
}

getMax <- function(x) {
  if (inherits(x, "SpatRaster")) {
    terra::global(x, "max", na.rm = TRUE)[[1]]
  } else {
    raster::cellStats(x, max)
  }
}
spp[[curSp()]]$rmm$code$wallace$transfer_curModel <- curModel()
spp[[curSp()]]$rmm$code$wallace$transfer_area <- TRUE


spp[[curSp()]]$rmm$data$transfer$environment1$minVal <-
  printVecAsis(getMin(xferExt), asChar = TRUE)
spp[[curSp()]]$rmm$data$transfer$environment1$maxVal <-
  printVecAsis(getMax(xferExt), asChar = TRUE)


if (spp[[curSp()]]$rmm$data$environment$sources == 'WorldClim 2.1') {
  spp[[curSp()]]$rmm$data$transfer$environment1$yearMin <- 1970
  spp[[curSp()]]$rmm$data$transfer$environment1$yearMax <- 2000
}
spp[[curSp()]]$rmm$data$transfer$environment1$resolution <-
  paste(round(raster::res(xferExt)[1] * 60, digits = 2), "degrees")
spp[[curSp()]]$rmm$data$transfer$environment1$extentSet <-
  printVecAsis(as.vector(xferExt@extent), asChar = TRUE)
spp[[curSp()]]$rmm$data$transfer$environment1$extentRule <-
  "transfer to user-selected new area"
spp[[curSp()]]$rmm$data$transfer$environment1$sources <-
  spp[[curSp()]]$rmm$data$environment$sources
spp[[curSp()]]$rmm$prediction$transfer$environment1$units <-
  ifelse(predType == "raw", "relative occurrence rate", predType)

spp[[curSp()]]$rmm$prediction$transfer$environment1$minVal <-
  printVecAsis(getMin(xferAreaThr), asChar = TRUE)
spp[[curSp()]]$rmm$prediction$transfer$environment1$maxVal <-
  printVecAsis(getMax(xferAreaThr), asChar = TRUE)
`