Do not throw errors, use callbacks in all errror and success cases

[bengtweisse]

Hey there,

you are throwing errors in some cases (like during message creation by default).
Please do not do this, because it will destroy async apps and nodejs lives from async!

if i deactivate websms.doThrowMessageCreationError then the error callback is async, but the success is sync. So I have to check on my own if the createdMessage is corrupt, because the error callback triggers later then the message sending.

It would be nice to have there a success and error callback.
So i can handle it not as dirty i have to do it, yet.
I could use a promise or put the sending block in the success callback of the creation statement.

In general nodejs approaches.
You may also use one callback for each websmscom function.
First argument would be the error or null/undefined and the second argument the successobject (created message or success of sending a message).

Thank you.

[reifi]

Thanks for the feedback, you are absolutely right about the single-callback for each function. It is a bad practice which was noticed too late 2 years ago.
This will change in v1.1.0.

For the handling of the message object creation I will hopefully find some time to look into it again and regard http://www.joyent.com/developers/node/design/errors#footnote-1-src

[bengtweisse]

Thank you for your quick response.
I check if after message creation the message object has a messageContent and the recipients list is not empty, yet. Is there any other constellation i have to prevent?

Thanks