-
Notifications
You must be signed in to change notification settings - Fork 12
Open
Description
The method as.matrix will convert a float32 vector into a float32 matrix.
However, as.matrix as used in other packages is meant to return a matrix object, which allows creating libraries that accept arbitrary objects from other packages without having to add them as dependencies - that is, one can create a library with a function that takes an input X, call as.matrix on it, and then pass it to a function that expects a matrix object, with the X potentially being a data.table, dgCMatrix, etc. (without adding dependencies on data.table or Matrix).
Would be nice if this package could follow this logic too, perhaps adding a different function as.float_matrix or the like that would do what as.matrix.float32 currently does.
Metadata
Metadata
Assignees
Labels
No labels