diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..fe6e1c2 --- /dev/null +++ b/.gitignore @@ -0,0 +1,111 @@ +# ============================================ +# Spring Boot (Java + Maven) +# ============================================ + +# Compiled class files +*.class +*.jar +*.war +*.ear + +# Logs +*.log +logs/ +spring.log + +# Temporary files +*.tmp +*.bak +*.swp +*.swo +*.old +*.orig + +# ============================================ +# Maven +# ============================================ +target/ +.mvn/ +!.mvn/wrapper/maven-wrapper.jar +.settings/ +dependency-reduced-pom.xml +release.properties +pom.xml.tag +pom.xml.releaseBackup +pom.xml.versionsBackup +pom.xml.next +pom.xml.backup +buildNumber.properties + +# ============================================ +# IntelliJ IDEA +# ============================================ +.idea/ +*.iml +*.iws +out/ +.idea_modules/ +.idea/workspace.xml +.idea/tasks.xml +.idea/dictionaries +.idea/httpRequests +.idea/caches/ +.idea/libraries/ + +# ============================================ +# VS Code (opcional si usas ambos IDEs) +# ============================================ +.vscode/ +.history/ + +# ============================================ +# Environment / Configuration +# ============================================ +.env +*.env.local +*.key +*.pem +*.crt +*.jks +*.p12 +*.der + +# Spring configuration files (keep templates only) +application-*.yml +application-*.yaml +application-*.properties +!application-example.yml +!application-example.yaml +!application-example.properties + +# ============================================ +# Test / Coverage +# ============================================ +test-output/ +surefire-reports/ +jacoco.exec +reports/ +coverage/ + +# ============================================ +# OS files +# ============================================ +# macOS +.DS_Store +.AppleDouble +.LSOverride + +# Windows +Thumbs.db +ehthumbs.db +Desktop.ini + +# Linux +*~ + +# ============================================ +# Misc +# ============================================ +bin/ +tmp/ +.cache/ diff --git a/README.md b/README.md index 7f832ad..0d5bf99 100644 --- a/README.md +++ b/README.md @@ -1,14 +1,11 @@ -# Yape Code Challenge :rocket: +# Transaction Service – Yape Code Challenge -Our code challenge will let you marvel us with your Jedi coding skills :smile:. +Este proyecto implementa un **microservicio de transacciones** desarrollado con **Spring Boot 3**, siguiendo el enfoque de **Arquitectura Hexagonal (Ports & Adapters)** y un **flujo event-driven con Kafka**. -Don't forget that the proper way to submit your work is to fork the repo and create a PR :wink: ... have fun !! -- [Yape Code Challenge :rocket:](#yape-code-challenge-rocket) -- [Problem](#problem) -- [Tech Stack](#tech-stack) - - [Optional](#optional) -- [Send us your challenge](#send-us-your-challenge) +Todos los endpoints intercambian datos en **JSON** y el sistema está preparado para ejecutarse **localmente con Docker Compose**. + +--- # Problem @@ -31,54 +28,191 @@ Every transaction with a value greater than 1000 should be rejected. Anti-Fraud -- Send transaction Status Rejected event--> Transaction Transaction -- Update transaction Status event--> transactionDatabase[(Database)] ``` +--- -# Tech Stack +## Arquitectura -
    -
  1. Java. You can use any framework you want
    2. -
  2. Any database
    3. -
  3. Kafka
    4. -
+El proyecto sigue **Arquitectura Hexagonal**, separando claramente responsabilidades: + +``` +├── application +│ ├── dto +│ ├── service +│ └── usecase +├── domain +│ ├── model +│ └── port +├── infrastructure +│ ├── inbound +│ │ ├── rest +│ │ └── kafka +│ ├── outbound +│ │ ├── persistence +│ │ └── kafka +│ └── config +``` + +--- + +## Ejecución local (sin Docker) + +### Requisitos +- Java 17 +- Maven 3.9+ +- PostgreSQL +- Kafka + Zookeeper + +### Compilar y ejecutar tests +```bash +mvn clean compile +mvn test +mvn verify +``` + +Reporte JaCoCo: +``` +target/site/jacoco/index.html +``` +## Docker Compose (PostgreSQL + Kafka + Transaction Service + Antifraud) + +### Requisitos +- Docker y Docker Compose + +### 1) Construir el `.jar` +Desde la raíz del proyecto (donde está el `pom.xml`): + +```bash +mvn clean package +``` + +El ejecutable jar se genera en: + +``` +target/transaction-service-0.0.1.jar +``` + +> empaquetar mas pruebas unitarias & cobertura: +> ```bash +> mvn clean verify +> ``` + +## ***Antifraud Service*** + +El servicio de **Antifraud** se encuentra implementado en un repositorio independiente y se integra con este microservicio mediante eventos Kafka. + +Repositorio: + https://github.com/alessandrojre/antifraud-service + +En el entorno local, el `docker-compose` levanta automáticamente este servicio para simular el flujo completo: +Transaction Service → Kafka → Antifraud Service → Kafka → Transaction Service. -We do provide a `Dockerfile` to help you get started with a dev environment. -You must have two resources: +## Levantar el ecosistema con Docker Compose -1. Resource to create a transaction that must containt: +Ubícate en la carpeta `devops` (donde está el `docker-compose.yml`) y ejecuta: +```bash + cd devops + docker compose up --build +``` + +Para ejecutar en segundo plano: + +```bash + docker compose up -d --build +``` +Ver contenedores activos: + +```bash + docker ps +``` +Para ver logs: + +```bash + docker compose logs -f +``` + +Para detener y eliminar contenedores: + +```bash + docker compose down +``` + +Para eliminar también el volumen de Postgres: + +```bash + docker compose down -v +``` + +--- + +## Probar endpoints REST + +### Crear transacción +```bash +curl --location --request POST 'http://localhost:8080/transactions' \ +--header 'Content-Type: application/json' \ +--data-raw '{ + "accountExternalIdDebit": "11111111-1111-1111-1111-111111111111", + "accountExternalIdCredit": "22222222-2222-2222-2222-222222222222", + "tranferTypeId": 1, + "value": 150.75 +}' +``` + +Response: ```json { - "accountExternalIdDebit": "Guid", - "accountExternalIdCredit": "Guid", - "tranferTypeId": 1, - "value": 120 + "transactionExternalId": "83a3d905-ee35-4201-9958-0fde4d7267b8" } ``` +--- + + -2. Resource to retrieve a transaction +### Obtener transacción por ID +```bash +curl --location --request GET \ +'http://localhost:8080/transactions/{transactionExternalId}' +``` +Response: ```json { - "transactionExternalId": "Guid", + "transactionExternalId": "83a3d905-ee35-4201-9958-0fde4d7267b8", "transactionType": { - "name": "" + "name": "TRANSFER" }, "transactionStatus": { - "name": "" + "name": "APPROVED" }, - "value": 120, - "createdAt": "Date" + "value": 150.75, + "createdAt": "2025-12-29T00:00:00Z" } ``` -## Optional +--- + +## Docker Compose -You can use any approach to store transaction data but you should consider that we may deal with high volume scenarios where we have a huge amount of writes and reads for the same data at the same time. How would you tackle this requirement? +Levantar todo el entorno: +```bash +docker-compose up --build +``` -You can use Graphql; +Servicios: +- Transaction Service → 8080 +- Antifraud Service → 8081 +- PostgreSQL → 5432 +- Kafka → 9092 -# Send us your challenge +--- -When you finish your challenge, after forking a repository, you **must** open a pull request to our repository. There are no limitations to the implementation, you can follow the programming paradigm, modularization, and style that you feel is the most appropriate solution. +## Stack Tecnológico -If you have any questions, please let us know. \ No newline at end of file +- Java 17 +- Spring Boot 3.5 +- PostgreSQL +- Kafka +- Docker +- JUnit 5 + Mockito + AssertJ + JaCoCo diff --git a/devops/Dockerfile b/devops/Dockerfile new file mode 100644 index 0000000..9a8c050 --- /dev/null +++ b/devops/Dockerfile @@ -0,0 +1,16 @@ +FROM eclipse-temurin:17-jre-alpine + +RUN addgroup -S spring && adduser -S spring -G spring +USER spring + +WORKDIR /app + +ARG JAR_FILE=../target/*.jar +COPY ${JAR_FILE} app.jar + +ENV JAVA_OPTS="" +ENV SPRING_PROFILES_ACTIVE=default + +EXPOSE 8080 + +ENTRYPOINT ["sh", "-c", "java $JAVA_OPTS -jar app.jar"] diff --git a/devops/antifraud/Dockerfile b/devops/antifraud/Dockerfile new file mode 100644 index 0000000..2d9b4e9 --- /dev/null +++ b/devops/antifraud/Dockerfile @@ -0,0 +1,13 @@ +FROM eclipse-temurin:17-jre-alpine + +RUN addgroup -S spring && adduser -S spring -G spring +USER spring + +WORKDIR /app + +COPY antifraud-service-0.0.1.jar app.jar + +ENV JAVA_OPTS="" +EXPOSE 8081 + +ENTRYPOINT ["sh", "-c", "java $JAVA_OPTS -jar app.jar"] diff --git a/devops/docker-compose.yml b/devops/docker-compose.yml new file mode 100644 index 0000000..e6dbcb5 --- /dev/null +++ b/devops/docker-compose.yml @@ -0,0 +1,90 @@ +version: "3.7" + +services: + postgres: + image: postgres:14 + container_name: postgres + ports: + - "5432:5432" + environment: + POSTGRES_DB: transactionsdb + POSTGRES_USER: postgres + POSTGRES_PASSWORD: postgres + volumes: + - pgdata:/var/lib/postgresql/data + + zookeeper: + image: confluentinc/cp-zookeeper:5.5.3 + container_name: zookeeper + environment: + ZOOKEEPER_CLIENT_PORT: 2181 + healthcheck: + test: ["CMD", "bash", "-c", "echo ruok | nc -w 2 localhost 2181 | grep imok"] + interval: 10s + timeout: 5s + retries: 10 + + kafka: + image: confluentinc/cp-enterprise-kafka:5.5.3 + container_name: kafka + depends_on: [zookeeper] + environment: + KAFKA_ZOOKEEPER_CONNECT: "zookeeper:2181" + KAFKA_ADVERTISED_LISTENERS: PLAINTEXT://kafka:29092,PLAINTEXT_HOST://localhost:9092 + KAFKA_LISTENER_SECURITY_PROTOCOL_MAP: PLAINTEXT:PLAINTEXT,PLAINTEXT_HOST:PLAINTEXT + KAFKA_BROKER_ID: 1 + KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR: 1 + KAFKA_JMX_PORT: 9991 + ports: + - "9092:9092" + healthcheck: + test: ["CMD", "bash", "-c", "kafka-topics --bootstrap-server kafka:29092 --list >/dev/null 2>&1"] + interval: 10s + timeout: 5s + retries: 10 + + # Crea tópicos necesarios para el flujo (una sola vez) + kafka-init: + image: confluentinc/cp-enterprise-kafka:5.5.3 + container_name: kafka-init + depends_on: [kafka] + command: > + bash -c " + kafka-topics --bootstrap-server kafka:29092 --create --if-not-exists --topic transaction.created --partitions 3 --replication-factor 1 && + kafka-topics --bootstrap-server kafka:29092 --create --if-not-exists --topic transaction.status.updated --partitions 3 --replication-factor 1 + " + restart: "no" + + transaction-service: + build: + context: .. + dockerfile: devops/Dockerfile + image: transaction-service:local + container_name: transaction-service + depends_on: + - postgres + - kafka + - kafka-init + environment: + SPRING_DATASOURCE_URL: jdbc:postgresql://postgres:5432/transactionsdb + SPRING_DATASOURCE_USERNAME: postgres + SPRING_DATASOURCE_PASSWORD: postgres + SPRING_KAFKA_BOOTSTRAP_SERVERS: kafka:29092 + ports: + - "8080:8080" + + antifraud-service: + build: + context: ./antifraud + dockerfile: Dockerfile + image: antifraud-service:local + container_name: antifraud-service + depends_on: + - kafka + - kafka-init + environment: + SPRING_KAFKA_BOOTSTRAP_SERVERS: kafka:29092 + ports: + - "8081:8081" +volumes: + pgdata: \ No newline at end of file diff --git a/docker-compose.yml b/docker-compose.yml deleted file mode 100644 index 6e9a9c5..0000000 --- a/docker-compose.yml +++ /dev/null @@ -1,25 +0,0 @@ -version: "3.7" -services: - postgres: - image: postgres:14 - ports: - - "5432:5432" - environment: - - POSTGRES_USER=postgres - - POSTGRES_PASSWORD=postgres - zookeeper: - image: confluentinc/cp-zookeeper:5.5.3 - environment: - ZOOKEEPER_CLIENT_PORT: 2181 - kafka: - image: confluentinc/cp-enterprise-kafka:5.5.3 - depends_on: [zookeeper] - environment: - KAFKA_ZOOKEEPER_CONNECT: "zookeeper:2181" - KAFKA_ADVERTISED_LISTENERS: PLAINTEXT://kafka:29092,PLAINTEXT_HOST://localhost:9092 - KAFKA_LISTENER_SECURITY_PROTOCOL_MAP: PLAINTEXT:PLAINTEXT,PLAINTEXT_HOST:PLAINTEXT - KAFKA_BROKER_ID: 1 - KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR: 1 - KAFKA_JMX_PORT: 9991 - ports: - - 9092:9092 \ No newline at end of file diff --git a/mvnw b/mvnw new file mode 100755 index 0000000..bd8896b --- /dev/null +++ b/mvnw @@ -0,0 +1,295 @@ +#!/bin/sh +# ---------------------------------------------------------------------------- +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# ---------------------------------------------------------------------------- + +# ---------------------------------------------------------------------------- +# Apache Maven Wrapper startup batch script, version 3.3.4 +# +# Optional ENV vars +# ----------------- +# JAVA_HOME - location of a JDK home dir, required when download maven via java source +# MVNW_REPOURL - repo url base for downloading maven distribution +# MVNW_USERNAME/MVNW_PASSWORD - user and password for downloading maven +# MVNW_VERBOSE - true: enable verbose log; debug: trace the mvnw script; others: silence the output +# ---------------------------------------------------------------------------- + +set -euf +[ "${MVNW_VERBOSE-}" != debug ] || set -x + +# OS specific support. +native_path() { printf %s\\n "$1"; } +case "$(uname)" in +CYGWIN* | MINGW*) + [ -z "${JAVA_HOME-}" ] || JAVA_HOME="$(cygpath --unix "$JAVA_HOME")" + native_path() { cygpath --path --windows "$1"; } + ;; +esac + +# set JAVACMD and JAVACCMD +set_java_home() { + # For Cygwin and MinGW, ensure paths are in Unix format before anything is touched + if [ -n "${JAVA_HOME-}" ]; then + if [ -x "$JAVA_HOME/jre/sh/java" ]; then + # IBM's JDK on AIX uses strange locations for the executables + JAVACMD="$JAVA_HOME/jre/sh/java" + JAVACCMD="$JAVA_HOME/jre/sh/javac" + else + JAVACMD="$JAVA_HOME/bin/java" + JAVACCMD="$JAVA_HOME/bin/javac" + + if [ ! -x "$JAVACMD" ] || [ ! -x "$JAVACCMD" ]; then + echo "The JAVA_HOME environment variable is not defined correctly, so mvnw cannot run." >&2 + echo "JAVA_HOME is set to \"$JAVA_HOME\", but \"\$JAVA_HOME/bin/java\" or \"\$JAVA_HOME/bin/javac\" does not exist." >&2 + return 1 + fi + fi + else + JAVACMD="$( + 'set' +e + 'unset' -f command 2>/dev/null + 'command' -v java + )" || : + JAVACCMD="$( + 'set' +e + 'unset' -f command 2>/dev/null + 'command' -v javac + )" || : + + if [ ! -x "${JAVACMD-}" ] || [ ! -x "${JAVACCMD-}" ]; then + echo "The java/javac command does not exist in PATH nor is JAVA_HOME set, so mvnw cannot run." >&2 + return 1 + fi + fi +} + +# hash string like Java String::hashCode +hash_string() { + str="${1:-}" h=0 + while [ -n "$str" ]; do + char="${str%"${str#?}"}" + h=$(((h * 31 + $(LC_CTYPE=C printf %d "'$char")) % 4294967296)) + str="${str#?}" + done + printf %x\\n $h +} + +verbose() { :; } +[ "${MVNW_VERBOSE-}" != true ] || verbose() { printf %s\\n "${1-}"; } + +die() { + printf %s\\n "$1" >&2 + exit 1 +} + +trim() { + # MWRAPPER-139: + # Trims trailing and leading whitespace, carriage returns, tabs, and linefeeds. + # Needed for removing poorly interpreted newline sequences when running in more + # exotic environments such as mingw bash on Windows. + printf "%s" "${1}" | tr -d '[:space:]' +} + +scriptDir="$(dirname "$0")" +scriptName="$(basename "$0")" + +# parse distributionUrl and optional distributionSha256Sum, requires .mvn/wrapper/maven-wrapper.properties +while IFS="=" read -r key value; do + case "${key-}" in + distributionUrl) distributionUrl=$(trim "${value-}") ;; + distributionSha256Sum) distributionSha256Sum=$(trim "${value-}") ;; + esac +done <"$scriptDir/.mvn/wrapper/maven-wrapper.properties" +[ -n "${distributionUrl-}" ] || die "cannot read distributionUrl property in $scriptDir/.mvn/wrapper/maven-wrapper.properties" + +case "${distributionUrl##*/}" in +maven-mvnd-*bin.*) + MVN_CMD=mvnd.sh _MVNW_REPO_PATTERN=/maven/mvnd/ + case "${PROCESSOR_ARCHITECTURE-}${PROCESSOR_ARCHITEW6432-}:$(uname -a)" in + *AMD64:CYGWIN* | *AMD64:MINGW*) distributionPlatform=windows-amd64 ;; + :Darwin*x86_64) distributionPlatform=darwin-amd64 ;; + :Darwin*arm64) distributionPlatform=darwin-aarch64 ;; + :Linux*x86_64*) distributionPlatform=linux-amd64 ;; + *) + echo "Cannot detect native platform for mvnd on $(uname)-$(uname -m), use pure java version" >&2 + distributionPlatform=linux-amd64 + ;; + esac + distributionUrl="${distributionUrl%-bin.*}-$distributionPlatform.zip" + ;; +maven-mvnd-*) MVN_CMD=mvnd.sh _MVNW_REPO_PATTERN=/maven/mvnd/ ;; +*) MVN_CMD="mvn${scriptName#mvnw}" _MVNW_REPO_PATTERN=/org/apache/maven/ ;; +esac + +# apply MVNW_REPOURL and calculate MAVEN_HOME +# maven home pattern: ~/.m2/wrapper/dists/{apache-maven-,maven-mvnd--}/ +[ -z "${MVNW_REPOURL-}" ] || distributionUrl="$MVNW_REPOURL$_MVNW_REPO_PATTERN${distributionUrl#*"$_MVNW_REPO_PATTERN"}" +distributionUrlName="${distributionUrl##*/}" +distributionUrlNameMain="${distributionUrlName%.*}" +distributionUrlNameMain="${distributionUrlNameMain%-bin}" +MAVEN_USER_HOME="${MAVEN_USER_HOME:-${HOME}/.m2}" +MAVEN_HOME="${MAVEN_USER_HOME}/wrapper/dists/${distributionUrlNameMain-}/$(hash_string "$distributionUrl")" + +exec_maven() { + unset MVNW_VERBOSE MVNW_USERNAME MVNW_PASSWORD MVNW_REPOURL || : + exec "$MAVEN_HOME/bin/$MVN_CMD" "$@" || die "cannot exec $MAVEN_HOME/bin/$MVN_CMD" +} + +if [ -d "$MAVEN_HOME" ]; then + verbose "found existing MAVEN_HOME at $MAVEN_HOME" + exec_maven "$@" +fi + +case "${distributionUrl-}" in +*?-bin.zip | *?maven-mvnd-?*-?*.zip) ;; +*) die "distributionUrl is not valid, must match *-bin.zip or maven-mvnd-*.zip, but found '${distributionUrl-}'" ;; +esac + +# prepare tmp dir +if TMP_DOWNLOAD_DIR="$(mktemp -d)" && [ -d "$TMP_DOWNLOAD_DIR" ]; then + clean() { rm -rf -- "$TMP_DOWNLOAD_DIR"; } + trap clean HUP INT TERM EXIT +else + die "cannot create temp dir" +fi + +mkdir -p -- "${MAVEN_HOME%/*}" + +# Download and Install Apache Maven +verbose "Couldn't find MAVEN_HOME, downloading and installing it ..." +verbose "Downloading from: $distributionUrl" +verbose "Downloading to: $TMP_DOWNLOAD_DIR/$distributionUrlName" + +# select .zip or .tar.gz +if ! command -v unzip >/dev/null; then + distributionUrl="${distributionUrl%.zip}.tar.gz" + distributionUrlName="${distributionUrl##*/}" +fi + +# verbose opt +__MVNW_QUIET_WGET=--quiet __MVNW_QUIET_CURL=--silent __MVNW_QUIET_UNZIP=-q __MVNW_QUIET_TAR='' +[ "${MVNW_VERBOSE-}" != true ] || __MVNW_QUIET_WGET='' __MVNW_QUIET_CURL='' __MVNW_QUIET_UNZIP='' __MVNW_QUIET_TAR=v + +# normalize http auth +case "${MVNW_PASSWORD:+has-password}" in +'') MVNW_USERNAME='' MVNW_PASSWORD='' ;; +has-password) [ -n "${MVNW_USERNAME-}" ] || MVNW_USERNAME='' MVNW_PASSWORD='' ;; +esac + +if [ -z "${MVNW_USERNAME-}" ] && command -v wget >/dev/null; then + verbose "Found wget ... using wget" + wget ${__MVNW_QUIET_WGET:+"$__MVNW_QUIET_WGET"} "$distributionUrl" -O "$TMP_DOWNLOAD_DIR/$distributionUrlName" || die "wget: Failed to fetch $distributionUrl" +elif [ -z "${MVNW_USERNAME-}" ] && command -v curl >/dev/null; then + verbose "Found curl ... using curl" + curl ${__MVNW_QUIET_CURL:+"$__MVNW_QUIET_CURL"} -f -L -o "$TMP_DOWNLOAD_DIR/$distributionUrlName" "$distributionUrl" || die "curl: Failed to fetch $distributionUrl" +elif set_java_home; then + verbose "Falling back to use Java to download" + javaSource="$TMP_DOWNLOAD_DIR/Downloader.java" + targetZip="$TMP_DOWNLOAD_DIR/$distributionUrlName" + cat >"$javaSource" <<-END + public class Downloader extends java.net.Authenticator + { + protected java.net.PasswordAuthentication getPasswordAuthentication() + { + return new java.net.PasswordAuthentication( System.getenv( "MVNW_USERNAME" ), System.getenv( "MVNW_PASSWORD" ).toCharArray() ); + } + public static void main( String[] args ) throws Exception + { + setDefault( new Downloader() ); + java.nio.file.Files.copy( java.net.URI.create( args[0] ).toURL().openStream(), java.nio.file.Paths.get( args[1] ).toAbsolutePath().normalize() ); + } + } + END + # For Cygwin/MinGW, switch paths to Windows format before running javac and java + verbose " - Compiling Downloader.java ..." + "$(native_path "$JAVACCMD")" "$(native_path "$javaSource")" || die "Failed to compile Downloader.java" + verbose " - Running Downloader.java ..." + "$(native_path "$JAVACMD")" -cp "$(native_path "$TMP_DOWNLOAD_DIR")" Downloader "$distributionUrl" "$(native_path "$targetZip")" +fi + +# If specified, validate the SHA-256 sum of the Maven distribution zip file +if [ -n "${distributionSha256Sum-}" ]; then + distributionSha256Result=false + if [ "$MVN_CMD" = mvnd.sh ]; then + echo "Checksum validation is not supported for maven-mvnd." >&2 + echo "Please disable validation by removing 'distributionSha256Sum' from your maven-wrapper.properties." >&2 + exit 1 + elif command -v sha256sum >/dev/null; then + if echo "$distributionSha256Sum $TMP_DOWNLOAD_DIR/$distributionUrlName" | sha256sum -c - >/dev/null 2>&1; then + distributionSha256Result=true + fi + elif command -v shasum >/dev/null; then + if echo "$distributionSha256Sum $TMP_DOWNLOAD_DIR/$distributionUrlName" | shasum -a 256 -c >/dev/null 2>&1; then + distributionSha256Result=true + fi + else + echo "Checksum validation was requested but neither 'sha256sum' or 'shasum' are available." >&2 + echo "Please install either command, or disable validation by removing 'distributionSha256Sum' from your maven-wrapper.properties." >&2 + exit 1 + fi + if [ $distributionSha256Result = false ]; then + echo "Error: Failed to validate Maven distribution SHA-256, your Maven distribution might be compromised." >&2 + echo "If you updated your Maven version, you need to update the specified distributionSha256Sum property." >&2 + exit 1 + fi +fi + +# unzip and move +if command -v unzip >/dev/null; then + unzip ${__MVNW_QUIET_UNZIP:+"$__MVNW_QUIET_UNZIP"} "$TMP_DOWNLOAD_DIR/$distributionUrlName" -d "$TMP_DOWNLOAD_DIR" || die "failed to unzip" +else + tar xzf${__MVNW_QUIET_TAR:+"$__MVNW_QUIET_TAR"} "$TMP_DOWNLOAD_DIR/$distributionUrlName" -C "$TMP_DOWNLOAD_DIR" || die "failed to untar" +fi + +# Find the actual extracted directory name (handles snapshots where filename != directory name) +actualDistributionDir="" + +# First try the expected directory name (for regular distributions) +if [ -d "$TMP_DOWNLOAD_DIR/$distributionUrlNameMain" ]; then + if [ -f "$TMP_DOWNLOAD_DIR/$distributionUrlNameMain/bin/$MVN_CMD" ]; then + actualDistributionDir="$distributionUrlNameMain" + fi +fi + +# If not found, search for any directory with the Maven executable (for snapshots) +if [ -z "$actualDistributionDir" ]; then + # enable globbing to iterate over items + set +f + for dir in "$TMP_DOWNLOAD_DIR"/*; do + if [ -d "$dir" ]; then + if [ -f "$dir/bin/$MVN_CMD" ]; then + actualDistributionDir="$(basename "$dir")" + break + fi + fi + done + set -f +fi + +if [ -z "$actualDistributionDir" ]; then + verbose "Contents of $TMP_DOWNLOAD_DIR:" + verbose "$(ls -la "$TMP_DOWNLOAD_DIR")" + die "Could not find Maven distribution directory in extracted archive" +fi + +verbose "Found extracted Maven distribution directory: $actualDistributionDir" +printf %s\\n "$distributionUrl" >"$TMP_DOWNLOAD_DIR/$actualDistributionDir/mvnw.url" +mv -- "$TMP_DOWNLOAD_DIR/$actualDistributionDir" "$MAVEN_HOME" || [ -d "$MAVEN_HOME" ] || die "fail to move MAVEN_HOME" + +clean || : +exec_maven "$@" diff --git a/mvnw.cmd b/mvnw.cmd new file mode 100644 index 0000000..92450f9 --- /dev/null +++ b/mvnw.cmd @@ -0,0 +1,189 @@ +<# : batch portion +@REM ---------------------------------------------------------------------------- +@REM Licensed to the Apache Software Foundation (ASF) under one +@REM or more contributor license agreements. See the NOTICE file +@REM distributed with this work for additional information +@REM regarding copyright ownership. The ASF licenses this file +@REM to you under the Apache License, Version 2.0 (the +@REM "License"); you may not use this file except in compliance +@REM with the License. You may obtain a copy of the License at +@REM +@REM http://www.apache.org/licenses/LICENSE-2.0 +@REM +@REM Unless required by applicable law or agreed to in writing, +@REM software distributed under the License is distributed on an +@REM "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +@REM KIND, either express or implied. See the License for the +@REM specific language governing permissions and limitations +@REM under the License. +@REM ---------------------------------------------------------------------------- + +@REM ---------------------------------------------------------------------------- +@REM Apache Maven Wrapper startup batch script, version 3.3.4 +@REM +@REM Optional ENV vars +@REM MVNW_REPOURL - repo url base for downloading maven distribution +@REM MVNW_USERNAME/MVNW_PASSWORD - user and password for downloading maven +@REM MVNW_VERBOSE - true: enable verbose log; others: silence the output +@REM ---------------------------------------------------------------------------- + +@IF "%__MVNW_ARG0_NAME__%"=="" (SET __MVNW_ARG0_NAME__=%~nx0) +@SET __MVNW_CMD__= +@SET __MVNW_ERROR__= +@SET __MVNW_PSMODULEP_SAVE=%PSModulePath% +@SET PSModulePath= +@FOR /F "usebackq tokens=1* delims==" %%A IN (`powershell -noprofile "& {$scriptDir='%~dp0'; $script='%__MVNW_ARG0_NAME__%'; icm -ScriptBlock ([Scriptblock]::Create((Get-Content -Raw '%~f0'))) -NoNewScope}"`) DO @( + IF "%%A"=="MVN_CMD" (set __MVNW_CMD__=%%B) ELSE IF "%%B"=="" (echo %%A) ELSE (echo %%A=%%B) +) +@SET PSModulePath=%__MVNW_PSMODULEP_SAVE% +@SET __MVNW_PSMODULEP_SAVE= +@SET __MVNW_ARG0_NAME__= +@SET MVNW_USERNAME= +@SET MVNW_PASSWORD= +@IF NOT "%__MVNW_CMD__%"=="" ("%__MVNW_CMD__%" %*) +@echo Cannot start maven from wrapper >&2 && exit /b 1 +@GOTO :EOF +: end batch / begin powershell #> + +$ErrorActionPreference = "Stop" +if ($env:MVNW_VERBOSE -eq "true") { + $VerbosePreference = "Continue" +} + +# calculate distributionUrl, requires .mvn/wrapper/maven-wrapper.properties +$distributionUrl = (Get-Content -Raw "$scriptDir/.mvn/wrapper/maven-wrapper.properties" | ConvertFrom-StringData).distributionUrl +if (!$distributionUrl) { + Write-Error "cannot read distributionUrl property in $scriptDir/.mvn/wrapper/maven-wrapper.properties" +} + +switch -wildcard -casesensitive ( $($distributionUrl -replace '^.*/','') ) { + "maven-mvnd-*" { + $USE_MVND = $true + $distributionUrl = $distributionUrl -replace '-bin\.[^.]*$',"-windows-amd64.zip" + $MVN_CMD = "mvnd.cmd" + break + } + default { + $USE_MVND = $false + $MVN_CMD = $script -replace '^mvnw','mvn' + break + } +} + +# apply MVNW_REPOURL and calculate MAVEN_HOME +# maven home pattern: ~/.m2/wrapper/dists/{apache-maven-,maven-mvnd--}/ +if ($env:MVNW_REPOURL) { + $MVNW_REPO_PATTERN = if ($USE_MVND -eq $False) { "/org/apache/maven/" } else { "/maven/mvnd/" } + $distributionUrl = "$env:MVNW_REPOURL$MVNW_REPO_PATTERN$($distributionUrl -replace "^.*$MVNW_REPO_PATTERN",'')" +} +$distributionUrlName = $distributionUrl -replace '^.*/','' +$distributionUrlNameMain = $distributionUrlName -replace '\.[^.]*$','' -replace '-bin$','' + +$MAVEN_M2_PATH = "$HOME/.m2" +if ($env:MAVEN_USER_HOME) { + $MAVEN_M2_PATH = "$env:MAVEN_USER_HOME" +} + +if (-not (Test-Path -Path $MAVEN_M2_PATH)) { + New-Item -Path $MAVEN_M2_PATH -ItemType Directory | Out-Null +} + +$MAVEN_WRAPPER_DISTS = $null +if ((Get-Item $MAVEN_M2_PATH).Target[0] -eq $null) { + $MAVEN_WRAPPER_DISTS = "$MAVEN_M2_PATH/wrapper/dists" +} else { + $MAVEN_WRAPPER_DISTS = (Get-Item $MAVEN_M2_PATH).Target[0] + "/wrapper/dists" +} + +$MAVEN_HOME_PARENT = "$MAVEN_WRAPPER_DISTS/$distributionUrlNameMain" +$MAVEN_HOME_NAME = ([System.Security.Cryptography.SHA256]::Create().ComputeHash([byte[]][char[]]$distributionUrl) | ForEach-Object {$_.ToString("x2")}) -join '' +$MAVEN_HOME = "$MAVEN_HOME_PARENT/$MAVEN_HOME_NAME" + +if (Test-Path -Path "$MAVEN_HOME" -PathType Container) { + Write-Verbose "found existing MAVEN_HOME at $MAVEN_HOME" + Write-Output "MVN_CMD=$MAVEN_HOME/bin/$MVN_CMD" + exit $? +} + +if (! $distributionUrlNameMain -or ($distributionUrlName -eq $distributionUrlNameMain)) { + Write-Error "distributionUrl is not valid, must end with *-bin.zip, but found $distributionUrl" +} + +# prepare tmp dir +$TMP_DOWNLOAD_DIR_HOLDER = New-TemporaryFile +$TMP_DOWNLOAD_DIR = New-Item -Itemtype Directory -Path "$TMP_DOWNLOAD_DIR_HOLDER.dir" +$TMP_DOWNLOAD_DIR_HOLDER.Delete() | Out-Null +trap { + if ($TMP_DOWNLOAD_DIR.Exists) { + try { Remove-Item $TMP_DOWNLOAD_DIR -Recurse -Force | Out-Null } + catch { Write-Warning "Cannot remove $TMP_DOWNLOAD_DIR" } + } +} + +New-Item -Itemtype Directory -Path "$MAVEN_HOME_PARENT" -Force | Out-Null + +# Download and Install Apache Maven +Write-Verbose "Couldn't find MAVEN_HOME, downloading and installing it ..." +Write-Verbose "Downloading from: $distributionUrl" +Write-Verbose "Downloading to: $TMP_DOWNLOAD_DIR/$distributionUrlName" + +$webclient = New-Object System.Net.WebClient +if ($env:MVNW_USERNAME -and $env:MVNW_PASSWORD) { + $webclient.Credentials = New-Object System.Net.NetworkCredential($env:MVNW_USERNAME, $env:MVNW_PASSWORD) +} +[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12 +$webclient.DownloadFile($distributionUrl, "$TMP_DOWNLOAD_DIR/$distributionUrlName") | Out-Null + +# If specified, validate the SHA-256 sum of the Maven distribution zip file +$distributionSha256Sum = (Get-Content -Raw "$scriptDir/.mvn/wrapper/maven-wrapper.properties" | ConvertFrom-StringData).distributionSha256Sum +if ($distributionSha256Sum) { + if ($USE_MVND) { + Write-Error "Checksum validation is not supported for maven-mvnd. `nPlease disable validation by removing 'distributionSha256Sum' from your maven-wrapper.properties." + } + Import-Module $PSHOME\Modules\Microsoft.PowerShell.Utility -Function Get-FileHash + if ((Get-FileHash "$TMP_DOWNLOAD_DIR/$distributionUrlName" -Algorithm SHA256).Hash.ToLower() -ne $distributionSha256Sum) { + Write-Error "Error: Failed to validate Maven distribution SHA-256, your Maven distribution might be compromised. If you updated your Maven version, you need to update the specified distributionSha256Sum property." + } +} + +# unzip and move +Expand-Archive "$TMP_DOWNLOAD_DIR/$distributionUrlName" -DestinationPath "$TMP_DOWNLOAD_DIR" | Out-Null + +# Find the actual extracted directory name (handles snapshots where filename != directory name) +$actualDistributionDir = "" + +# First try the expected directory name (for regular distributions) +$expectedPath = Join-Path "$TMP_DOWNLOAD_DIR" "$distributionUrlNameMain" +$expectedMvnPath = Join-Path "$expectedPath" "bin/$MVN_CMD" +if ((Test-Path -Path $expectedPath -PathType Container) -and (Test-Path -Path $expectedMvnPath -PathType Leaf)) { + $actualDistributionDir = $distributionUrlNameMain +} + +# If not found, search for any directory with the Maven executable (for snapshots) +if (!$actualDistributionDir) { + Get-ChildItem -Path "$TMP_DOWNLOAD_DIR" -Directory | ForEach-Object { + $testPath = Join-Path $_.FullName "bin/$MVN_CMD" + if (Test-Path -Path $testPath -PathType Leaf) { + $actualDistributionDir = $_.Name + } + } +} + +if (!$actualDistributionDir) { + Write-Error "Could not find Maven distribution directory in extracted archive" +} + +Write-Verbose "Found extracted Maven distribution directory: $actualDistributionDir" +Rename-Item -Path "$TMP_DOWNLOAD_DIR/$actualDistributionDir" -NewName $MAVEN_HOME_NAME | Out-Null +try { + Move-Item -Path "$TMP_DOWNLOAD_DIR/$MAVEN_HOME_NAME" -Destination $MAVEN_HOME_PARENT | Out-Null +} catch { + if (! (Test-Path -Path "$MAVEN_HOME" -PathType Container)) { + Write-Error "fail to move MAVEN_HOME" + } +} finally { + try { Remove-Item $TMP_DOWNLOAD_DIR -Recurse -Force | Out-Null } + catch { Write-Warning "Cannot remove $TMP_DOWNLOAD_DIR" } +} + +Write-Output "MVN_CMD=$MAVEN_HOME/bin/$MVN_CMD" diff --git a/pom.xml b/pom.xml new file mode 100644 index 0000000..241d45d --- /dev/null +++ b/pom.xml @@ -0,0 +1,204 @@ + + + 4.0.0 + + + org.springframework.boot + spring-boot-starter-parent + 3.5.7 + + + + com.yape + transaction-service + 0.0.1 + Transaction Service + Yape Code Challenge - Transaction Service + + + 17 + UTF-8 + 3.25.3 + 0.8.12 + 3.2.5 + 2.18.0 + + + + + + commons-beanutils + commons-beanutils + 1.11.0 + + + + + + + + org.springframework.boot + spring-boot-starter-web + + + + org.springframework.boot + spring-boot-starter-validation + + + + org.springframework.boot + spring-boot-starter-data-jpa + + + + org.postgresql + postgresql + runtime + + + + org.projectlombok + lombok + true + + + + org.springframework.boot + spring-boot-starter-test + test + + + + commons-io + commons-io + ${commons-io.version} + + + + org.springframework.kafka + spring-kafka + + + org.lz4 + lz4-java + + + + + + org.springframework.kafka + spring-kafka-test + test + + + org.lz4 + lz4-java + + + + + + at.yawk.lz4 + lz4-java + 1.10.1 + + + + org.assertj + assertj-core + ${assertj.version} + test + + + + + + + + + org.apache.maven.plugins + maven-surefire-plugin + ${maven.surefire.version} + + false + + + + + org.jacoco + jacoco-maven-plugin + ${jacoco.version} + + + + prepare-agent + + prepare-agent + + initialize + + + + report + verify + + report + + + + + jacoco-check + + check + + verify + + + + BUNDLE + + + LINE + COVEREDRATIO + 0.80 + + + + + + + + + + + **/*Application.class + **/infrastructure/config/** + + + + + + org.springframework.boot + spring-boot-maven-plugin + + + + org.apache.maven.plugins + maven-compiler-plugin + + ${java.version} + + + org.projectlombok + lombok + + + + + + + + diff --git a/src/main/java/com/yape/transaction/MainApplication.java b/src/main/java/com/yape/transaction/MainApplication.java new file mode 100644 index 0000000..02a0193 --- /dev/null +++ b/src/main/java/com/yape/transaction/MainApplication.java @@ -0,0 +1,13 @@ +package com.yape.transaction; + +import org.springframework.boot.SpringApplication; +import org.springframework.boot.autoconfigure.SpringBootApplication; + +@SpringBootApplication +public class MainApplication { + + public static void main(String[] args) { + SpringApplication.run(MainApplication.class, args); + } + +} diff --git a/src/main/java/com/yape/transaction/application/dto/CreateTransactionCommand.java b/src/main/java/com/yape/transaction/application/dto/CreateTransactionCommand.java new file mode 100644 index 0000000..4b831ab --- /dev/null +++ b/src/main/java/com/yape/transaction/application/dto/CreateTransactionCommand.java @@ -0,0 +1,11 @@ +package com.yape.transaction.application.dto; + +import java.math.BigDecimal; +import java.util.UUID; + +public record CreateTransactionCommand( + UUID accountExternalIdDebit, + UUID accountExternalIdCredit, + Integer tranferTypeId, + BigDecimal value +) {} \ No newline at end of file diff --git a/src/main/java/com/yape/transaction/application/dto/TransactionView.java b/src/main/java/com/yape/transaction/application/dto/TransactionView.java new file mode 100644 index 0000000..f07ecab --- /dev/null +++ b/src/main/java/com/yape/transaction/application/dto/TransactionView.java @@ -0,0 +1,14 @@ +package com.yape.transaction.application.dto; + + +import java.math.BigDecimal; +import java.time.Instant; +import java.util.UUID; + +public record TransactionView( + UUID transactionExternalId, + String transactionTypeName, + String transactionStatusName, + BigDecimal value, + Instant createdAt +) {} \ No newline at end of file diff --git a/src/main/java/com/yape/transaction/application/service/TransactionService.java b/src/main/java/com/yape/transaction/application/service/TransactionService.java new file mode 100644 index 0000000..7b6f8fb --- /dev/null +++ b/src/main/java/com/yape/transaction/application/service/TransactionService.java @@ -0,0 +1,81 @@ +package com.yape.transaction.application.service; + +import com.yape.transaction.application.dto.CreateTransactionCommand; +import com.yape.transaction.application.dto.TransactionView; +import com.yape.transaction.application.usecase.CreateTransactionUseCase; +import com.yape.transaction.application.usecase.GetTransactionUseCase; +import com.yape.transaction.application.usecase.UpdateTransactionStatusUseCase; +import com.yape.transaction.domain.model.Transaction; +import com.yape.transaction.domain.model.TransactionStatus; +import com.yape.transaction.domain.model.TransactionType; +import com.yape.transaction.domain.port.TransactionEventPublisherPort; +import com.yape.transaction.domain.port.TransactionRepositoryPort; + +import java.util.UUID; + +public class TransactionService implements UpdateTransactionStatusUseCase, + CreateTransactionUseCase, GetTransactionUseCase { + + private final TransactionRepositoryPort repository; + private final TransactionEventPublisherPort publisher; + + public TransactionService(TransactionRepositoryPort repository, + TransactionEventPublisherPort publisher) { + this.repository = repository; + this.publisher = publisher; + } + + @Override + public UUID create(CreateTransactionCommand command) { + + TransactionType type = mapType(command.tranferTypeId()); + + Transaction transaction = Transaction.createPending( + command.accountExternalIdDebit(), + command.accountExternalIdCredit(), + type, + command.value() + ); + + repository.save(transaction); + publisher.publishTransactionCreated(transaction); + + return transaction.getId(); + } + + @Override + public TransactionView getById(UUID transactionExternalId) { + Transaction transaction = repository.findById(transactionExternalId) + .orElseThrow(() -> new IllegalArgumentException("Transaction not found: " + transactionExternalId)); + + return new TransactionView( + transaction.getId(), + transaction.getType().name(), + transaction.getStatus().name(), + transaction.getValue(), + transaction.getCreatedAt() + ); + } + + @Override + public void updateStatus(UUID transactionExternalId, String newStatus) { + + var transaction = repository.findById(transactionExternalId) + .orElseThrow(() -> new IllegalArgumentException("Transaction not found: " + transactionExternalId)); + + var status = TransactionStatus.valueOf(newStatus.toUpperCase()); + + transaction.updateStatus(status); + repository.save(transaction); + } + + private TransactionType mapType(Integer tranferTypeId) { + if (tranferTypeId == null) { + throw new IllegalArgumentException("tranferTypeId is required"); + } + if (tranferTypeId == 1) { + return TransactionType.TRANSFER; + } + throw new IllegalArgumentException("Unsupported tranferTypeId: " + tranferTypeId); + } +} diff --git a/src/main/java/com/yape/transaction/application/usecase/CreateTransactionUseCase.java b/src/main/java/com/yape/transaction/application/usecase/CreateTransactionUseCase.java new file mode 100644 index 0000000..519c66e --- /dev/null +++ b/src/main/java/com/yape/transaction/application/usecase/CreateTransactionUseCase.java @@ -0,0 +1,8 @@ +package com.yape.transaction.application.usecase; + +import com.yape.transaction.application.dto.CreateTransactionCommand; +import java.util.UUID; + +public interface CreateTransactionUseCase { + UUID create(CreateTransactionCommand command); +} \ No newline at end of file diff --git a/src/main/java/com/yape/transaction/application/usecase/GetTransactionUseCase.java b/src/main/java/com/yape/transaction/application/usecase/GetTransactionUseCase.java new file mode 100644 index 0000000..a7219fb --- /dev/null +++ b/src/main/java/com/yape/transaction/application/usecase/GetTransactionUseCase.java @@ -0,0 +1,9 @@ +package com.yape.transaction.application.usecase; + +import com.yape.transaction.application.dto.TransactionView; + +import java.util.UUID; + +public interface GetTransactionUseCase { + TransactionView getById(UUID transactionExternalId); +} \ No newline at end of file diff --git a/src/main/java/com/yape/transaction/application/usecase/UpdateTransactionStatusUseCase.java b/src/main/java/com/yape/transaction/application/usecase/UpdateTransactionStatusUseCase.java new file mode 100644 index 0000000..aa7d5d5 --- /dev/null +++ b/src/main/java/com/yape/transaction/application/usecase/UpdateTransactionStatusUseCase.java @@ -0,0 +1,7 @@ +package com.yape.transaction.application.usecase; + +import java.util.UUID; + +public interface UpdateTransactionStatusUseCase { + void updateStatus(UUID transactionExternalId, String newStatus); +} diff --git a/src/main/java/com/yape/transaction/domain/model/Transaction.java b/src/main/java/com/yape/transaction/domain/model/Transaction.java new file mode 100644 index 0000000..06619c9 --- /dev/null +++ b/src/main/java/com/yape/transaction/domain/model/Transaction.java @@ -0,0 +1,61 @@ +package com.yape.transaction.domain.model; + +import java.math.BigDecimal; +import java.time.Instant; +import java.util.UUID; + +public class Transaction { + + private final UUID id; + private final UUID accountExternalIdDebit; + private final UUID accountExternalIdCredit; + private final TransactionType type; + private final BigDecimal value; + private final Instant createdAt; + + private TransactionStatus status; + + public Transaction(UUID id, + UUID accountExternalIdDebit, + UUID accountExternalIdCredit, + TransactionType type, + BigDecimal value, + TransactionStatus status, + Instant createdAt) { + this.id = id; + this.accountExternalIdDebit = accountExternalIdDebit; + this.accountExternalIdCredit = accountExternalIdCredit; + this.type = type; + this.value = value; + this.status = status; + this.createdAt = createdAt; + } + + public void updateStatus(TransactionStatus newStatus) { + if (newStatus == null) throw new IllegalArgumentException("status is required"); + this.status = newStatus; + } + + public static Transaction createPending(UUID debit, UUID credit, TransactionType type, BigDecimal value) { + return new Transaction( + UUID.randomUUID(), + debit, + credit, + type, + value, + TransactionStatus.PENDING, + Instant.now() + ); + } + + public UUID getId() { return id; } + public UUID getAccountExternalIdDebit() { return accountExternalIdDebit; } + public UUID getAccountExternalIdCredit() { return accountExternalIdCredit; } + public TransactionType getType() { return type; } + public BigDecimal getValue() { return value; } + public TransactionStatus getStatus() { return status; } + public Instant getCreatedAt() { return createdAt; } + + public void approve() { this.status = TransactionStatus.APPROVED; } + public void reject() { this.status = TransactionStatus.REJECTED; } +} \ No newline at end of file diff --git a/src/main/java/com/yape/transaction/domain/model/TransactionStatus.java b/src/main/java/com/yape/transaction/domain/model/TransactionStatus.java new file mode 100644 index 0000000..b4da76c --- /dev/null +++ b/src/main/java/com/yape/transaction/domain/model/TransactionStatus.java @@ -0,0 +1,7 @@ +package com.yape.transaction.domain.model; + +public enum TransactionStatus { + PENDING, + APPROVED, + REJECTED +} \ No newline at end of file diff --git a/src/main/java/com/yape/transaction/domain/model/TransactionType.java b/src/main/java/com/yape/transaction/domain/model/TransactionType.java new file mode 100644 index 0000000..cbacbf6 --- /dev/null +++ b/src/main/java/com/yape/transaction/domain/model/TransactionType.java @@ -0,0 +1,5 @@ +package com.yape.transaction.domain.model; + +public enum TransactionType { + TRANSFER +} \ No newline at end of file diff --git a/src/main/java/com/yape/transaction/domain/port/TransactionEventPublisherPort.java b/src/main/java/com/yape/transaction/domain/port/TransactionEventPublisherPort.java new file mode 100644 index 0000000..7d4f8e9 --- /dev/null +++ b/src/main/java/com/yape/transaction/domain/port/TransactionEventPublisherPort.java @@ -0,0 +1,7 @@ +package com.yape.transaction.domain.port; + +import com.yape.transaction.domain.model.Transaction; + +public interface TransactionEventPublisherPort { + void publishTransactionCreated(Transaction transaction); +} \ No newline at end of file diff --git a/src/main/java/com/yape/transaction/domain/port/TransactionRepositoryPort.java b/src/main/java/com/yape/transaction/domain/port/TransactionRepositoryPort.java new file mode 100644 index 0000000..df1e2f1 --- /dev/null +++ b/src/main/java/com/yape/transaction/domain/port/TransactionRepositoryPort.java @@ -0,0 +1,12 @@ +package com.yape.transaction.domain.port; + +import com.yape.transaction.domain.model.Transaction; +import java.util.Optional; +import java.util.UUID; + +public interface TransactionRepositoryPort { + + Transaction save(Transaction transaction); + + Optional findById(UUID transactionId); +} \ No newline at end of file diff --git a/src/main/java/com/yape/transaction/infrastructure/config/ApplicationBeansConfig.java b/src/main/java/com/yape/transaction/infrastructure/config/ApplicationBeansConfig.java new file mode 100644 index 0000000..7d16a6d --- /dev/null +++ b/src/main/java/com/yape/transaction/infrastructure/config/ApplicationBeansConfig.java @@ -0,0 +1,17 @@ +package com.yape.transaction.infrastructure.config; + +import com.yape.transaction.application.service.TransactionService; +import com.yape.transaction.domain.port.TransactionEventPublisherPort; +import com.yape.transaction.domain.port.TransactionRepositoryPort; +import org.springframework.context.annotation.Bean; +import org.springframework.context.annotation.Configuration; + +@Configuration +public class ApplicationBeansConfig { + + @Bean + public TransactionService transactionService(TransactionRepositoryPort repository, + TransactionEventPublisherPort publisher) { + return new TransactionService(repository, publisher); + } +} diff --git a/src/main/java/com/yape/transaction/infrastructure/config/KafkaConsumerConfig.java b/src/main/java/com/yape/transaction/infrastructure/config/KafkaConsumerConfig.java new file mode 100644 index 0000000..87820fd --- /dev/null +++ b/src/main/java/com/yape/transaction/infrastructure/config/KafkaConsumerConfig.java @@ -0,0 +1,41 @@ +package com.yape.transaction.infrastructure.config; + +import org.apache.kafka.clients.consumer.ConsumerConfig; +import org.apache.kafka.common.serialization.StringDeserializer; +import org.springframework.context.annotation.Bean; +import org.springframework.context.annotation.Configuration; +import org.springframework.core.env.Environment; +import org.springframework.kafka.config.ConcurrentKafkaListenerContainerFactory; +import org.springframework.kafka.core.*; + +import java.util.HashMap; +import java.util.Map; + +@Configuration +public class KafkaConsumerConfig { + + @Bean + public ConsumerFactory consumerFactory(Environment env) { + String bootstrapServers = env.getProperty("spring.kafka.bootstrap-servers", "kafka:29092"); + + Map props = new HashMap<>(); + props.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, bootstrapServers); + props.put(ConsumerConfig.GROUP_ID_CONFIG, "transaction-service"); + props.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, "latest"); + + props.put(ConsumerConfig.KEY_DESERIALIZER_CLASS_CONFIG, StringDeserializer.class); + props.put(ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG, StringDeserializer.class); + + return new DefaultKafkaConsumerFactory<>(props); + } + + @Bean + public ConcurrentKafkaListenerContainerFactory kafkaListenerContainerFactory( + ConsumerFactory consumerFactory + ) { + ConcurrentKafkaListenerContainerFactory factory = + new ConcurrentKafkaListenerContainerFactory<>(); + factory.setConsumerFactory(consumerFactory); + return factory; + } +} diff --git a/src/main/java/com/yape/transaction/infrastructure/config/KafkaProducerConfig.java b/src/main/java/com/yape/transaction/infrastructure/config/KafkaProducerConfig.java new file mode 100644 index 0000000..131bc13 --- /dev/null +++ b/src/main/java/com/yape/transaction/infrastructure/config/KafkaProducerConfig.java @@ -0,0 +1,34 @@ +package com.yape.transaction.infrastructure.config; + +import org.apache.kafka.clients.producer.ProducerConfig; +import org.apache.kafka.common.serialization.StringSerializer; +import org.springframework.context.annotation.Bean; +import org.springframework.context.annotation.Configuration; +import org.springframework.kafka.core.*; +import org.springframework.kafka.support.serializer.JsonSerializer; + +import java.util.HashMap; +import java.util.Map; + +@Configuration +public class KafkaProducerConfig { + + @Bean + public ProducerFactory producerFactory(org.springframework.core.env.Environment env) { + String bootstrapServers = env.getProperty("spring.kafka.bootstrap-servers", "kafka:29092"); + + Map props = new HashMap<>(); + props.put(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, bootstrapServers); + props.put(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG, StringSerializer.class); + props.put(ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG, JsonSerializer.class); + + props.put(JsonSerializer.ADD_TYPE_INFO_HEADERS, false); + + return new DefaultKafkaProducerFactory<>(props); + } + + @Bean + public KafkaTemplate kafkaTemplate(ProducerFactory producerFactory) { + return new KafkaTemplate<>(producerFactory); + } +} diff --git a/src/main/java/com/yape/transaction/infrastructure/inbound/kafka/TransactionStatusUpdatedConsumer.java b/src/main/java/com/yape/transaction/infrastructure/inbound/kafka/TransactionStatusUpdatedConsumer.java new file mode 100644 index 0000000..a5cbf21 --- /dev/null +++ b/src/main/java/com/yape/transaction/infrastructure/inbound/kafka/TransactionStatusUpdatedConsumer.java @@ -0,0 +1,38 @@ +package com.yape.transaction.infrastructure.inbound.kafka; + +import com.fasterxml.jackson.databind.ObjectMapper; +import com.yape.transaction.application.usecase.UpdateTransactionStatusUseCase; +import com.yape.transaction.infrastructure.outbound.kafka.KafkaTopics; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.kafka.annotation.KafkaListener; +import org.springframework.stereotype.Component; + +@Component +public class TransactionStatusUpdatedConsumer { + + private static final Logger log = + LoggerFactory.getLogger(TransactionStatusUpdatedConsumer.class); + private final UpdateTransactionStatusUseCase useCase; + private final ObjectMapper objectMapper; + + public TransactionStatusUpdatedConsumer(UpdateTransactionStatusUseCase useCase, + ObjectMapper objectMapper) { + this.useCase = useCase; + this.objectMapper = objectMapper; + } + + @KafkaListener(topics = KafkaTopics.TRANSACTION_STATUS_UPDATED, + groupId = "transaction-service") + public void onMessage(String message) { + try { + TransactionStatusUpdatedEvent event = + objectMapper.readValue(message, TransactionStatusUpdatedEvent.class); + + useCase.updateStatus(event.transactionExternalId(), event.status()); + + } catch (Exception e) { + log.error("Error processing transaction.status.updated message: {}", message, e); + } + } +} diff --git a/src/main/java/com/yape/transaction/infrastructure/inbound/kafka/TransactionStatusUpdatedEvent.java b/src/main/java/com/yape/transaction/infrastructure/inbound/kafka/TransactionStatusUpdatedEvent.java new file mode 100644 index 0000000..56902bd --- /dev/null +++ b/src/main/java/com/yape/transaction/infrastructure/inbound/kafka/TransactionStatusUpdatedEvent.java @@ -0,0 +1,8 @@ +package com.yape.transaction.infrastructure.inbound.kafka; + +import java.util.UUID; + +public record TransactionStatusUpdatedEvent( + UUID transactionExternalId, + String status +) {} \ No newline at end of file diff --git a/src/main/java/com/yape/transaction/infrastructure/inbound/rest/CreateTransactionRequest.java b/src/main/java/com/yape/transaction/infrastructure/inbound/rest/CreateTransactionRequest.java new file mode 100644 index 0000000..13b76bc --- /dev/null +++ b/src/main/java/com/yape/transaction/infrastructure/inbound/rest/CreateTransactionRequest.java @@ -0,0 +1,14 @@ +package com.yape.transaction.infrastructure.inbound.rest; + +import jakarta.validation.constraints.DecimalMin; +import jakarta.validation.constraints.NotNull; + +import java.math.BigDecimal; +import java.util.UUID; + +public record CreateTransactionRequest( + @NotNull UUID accountExternalIdDebit, + @NotNull UUID accountExternalIdCredit, + @NotNull Integer tranferTypeId, + @NotNull @DecimalMin(value = "0.01") BigDecimal value +) {} diff --git a/src/main/java/com/yape/transaction/infrastructure/inbound/rest/TransactionController.java b/src/main/java/com/yape/transaction/infrastructure/inbound/rest/TransactionController.java new file mode 100644 index 0000000..cfd9554 --- /dev/null +++ b/src/main/java/com/yape/transaction/infrastructure/inbound/rest/TransactionController.java @@ -0,0 +1,55 @@ +package com.yape.transaction.infrastructure.inbound.rest; + +import com.yape.transaction.application.dto.CreateTransactionCommand; +import com.yape.transaction.application.dto.TransactionView; +import com.yape.transaction.application.usecase.CreateTransactionUseCase; +import com.yape.transaction.application.usecase.GetTransactionUseCase; +import jakarta.validation.Valid; +import org.springframework.http.HttpStatus; +import org.springframework.validation.annotation.Validated; +import org.springframework.web.bind.annotation.*; + +import java.util.Map; +import java.util.UUID; + +@RestController +@Validated +@RequestMapping("/transactions") +public class TransactionController { + + private final CreateTransactionUseCase createUseCase; + private final GetTransactionUseCase getUseCase; + + public TransactionController(CreateTransactionUseCase createUseCase, + GetTransactionUseCase getUseCase) { + this.createUseCase = createUseCase; + this.getUseCase = getUseCase; + } + + @PostMapping + @ResponseStatus(HttpStatus.CREATED) + public Map create(@Valid @RequestBody CreateTransactionRequest request) { + + UUID id = createUseCase.create(new CreateTransactionCommand( + request.accountExternalIdDebit(), + request.accountExternalIdCredit(), + request.tranferTypeId(), + request.value() + )); + + return Map.of("transactionExternalId", id); + } + + @GetMapping("/{transactionExternalId}") + public TransactionResponse get(@PathVariable UUID transactionExternalId) { + TransactionView view = getUseCase.getById(transactionExternalId); + + return new TransactionResponse( + view.transactionExternalId(), + new TransactionResponse.TransactionTypeResponse(view.transactionTypeName()), + new TransactionResponse.TransactionStatusResponse(view.transactionStatusName()), + view.value(), + view.createdAt() + ); + } +} diff --git a/src/main/java/com/yape/transaction/infrastructure/inbound/rest/TransactionResponse.java b/src/main/java/com/yape/transaction/infrastructure/inbound/rest/TransactionResponse.java new file mode 100644 index 0000000..0bfe0b4 --- /dev/null +++ b/src/main/java/com/yape/transaction/infrastructure/inbound/rest/TransactionResponse.java @@ -0,0 +1,16 @@ +package com.yape.transaction.infrastructure.inbound.rest; + +import java.math.BigDecimal; +import java.time.Instant; +import java.util.UUID; + +public record TransactionResponse( + UUID transactionExternalId, + TransactionTypeResponse transactionType, + TransactionStatusResponse transactionStatus, + BigDecimal value, + Instant createdAt +) { + public record TransactionTypeResponse(String name) {} + public record TransactionStatusResponse(String name) {} +} diff --git a/src/main/java/com/yape/transaction/infrastructure/inbound/rest/exception/ApiExceptionHandler.java b/src/main/java/com/yape/transaction/infrastructure/inbound/rest/exception/ApiExceptionHandler.java new file mode 100644 index 0000000..847014d --- /dev/null +++ b/src/main/java/com/yape/transaction/infrastructure/inbound/rest/exception/ApiExceptionHandler.java @@ -0,0 +1,39 @@ +package com.yape.transaction.infrastructure.inbound.rest.exception; + +import jakarta.servlet.http.HttpServletRequest; +import org.springframework.http.HttpStatus; +import org.springframework.http.ResponseEntity; +import org.springframework.web.bind.MethodArgumentNotValidException; +import org.springframework.web.bind.annotation.ExceptionHandler; +import org.springframework.web.bind.annotation.RestControllerAdvice; + +import java.util.List; +import java.util.stream.Collectors; + +@RestControllerAdvice +public class ApiExceptionHandler { + + @ExceptionHandler(MethodArgumentNotValidException.class) + public ResponseEntity handleValidation(MethodArgumentNotValidException ex) { + List items = ex.getBindingResult().getFieldErrors() + .stream() + .map(fe -> new FieldErrorItem(fe.getField(), fe.getDefaultMessage())) + .collect(Collectors.toList()); + + return ResponseEntity.badRequest() + .body(ErrorResponse.of("Solicitud inválida", items)); + } + + @ExceptionHandler(BusinessException.class) + public ResponseEntity handleBusiness(BusinessException ex) { + return ResponseEntity.status(HttpStatus.BAD_REQUEST) + .body(ErrorResponse.of(ex.getMessage())); + } + + @ExceptionHandler(Exception.class) + public ResponseEntity handleGeneric(Exception ex, HttpServletRequest req) { + return ResponseEntity.status(HttpStatus.INTERNAL_SERVER_ERROR) + .body(ErrorResponse.of("Error interno del servidor")); + } + +} diff --git a/src/main/java/com/yape/transaction/infrastructure/inbound/rest/exception/BusinessException.java b/src/main/java/com/yape/transaction/infrastructure/inbound/rest/exception/BusinessException.java new file mode 100644 index 0000000..cf2251d --- /dev/null +++ b/src/main/java/com/yape/transaction/infrastructure/inbound/rest/exception/BusinessException.java @@ -0,0 +1,5 @@ +package com.yape.transaction.infrastructure.inbound.rest.exception; + +public class BusinessException extends RuntimeException { + public BusinessException(String message) { super(message); } +} diff --git a/src/main/java/com/yape/transaction/infrastructure/inbound/rest/exception/ErrorResponse.java b/src/main/java/com/yape/transaction/infrastructure/inbound/rest/exception/ErrorResponse.java new file mode 100644 index 0000000..9753df1 --- /dev/null +++ b/src/main/java/com/yape/transaction/infrastructure/inbound/rest/exception/ErrorResponse.java @@ -0,0 +1,35 @@ +package com.yape.transaction.infrastructure.inbound.rest.exception; + +import lombok.Getter; +import lombok.NoArgsConstructor; +import lombok.Setter; + +import java.util.List; + +@Getter +@Setter +@NoArgsConstructor +public class ErrorResponse { + + private String message; + private List errors; + + public ErrorResponse(String message) { + this.message = message; + } + + public ErrorResponse(String message, List errors) { + this.message = message; + this.errors = errors; + } + + public static ErrorResponse of(String message) { + return new ErrorResponse(message); + } + + public static ErrorResponse of(String message, List errors) { + return new ErrorResponse(message, (errors == null || errors.isEmpty()) ? null : errors); + } + + +} diff --git a/src/main/java/com/yape/transaction/infrastructure/inbound/rest/exception/FieldErrorItem.java b/src/main/java/com/yape/transaction/infrastructure/inbound/rest/exception/FieldErrorItem.java new file mode 100644 index 0000000..710b4bc --- /dev/null +++ b/src/main/java/com/yape/transaction/infrastructure/inbound/rest/exception/FieldErrorItem.java @@ -0,0 +1,16 @@ +package com.yape.transaction.infrastructure.inbound.rest.exception; + +import lombok.AllArgsConstructor; +import lombok.Getter; +import lombok.NoArgsConstructor; +import lombok.Setter; + +@Getter +@Setter +@NoArgsConstructor +@AllArgsConstructor +public class FieldErrorItem { + + private String field; + private String message; +} diff --git a/src/main/java/com/yape/transaction/infrastructure/outbound/kafka/KafkaTopics.java b/src/main/java/com/yape/transaction/infrastructure/outbound/kafka/KafkaTopics.java new file mode 100644 index 0000000..b07a86a --- /dev/null +++ b/src/main/java/com/yape/transaction/infrastructure/outbound/kafka/KafkaTopics.java @@ -0,0 +1,8 @@ +package com.yape.transaction.infrastructure.outbound.kafka; + +public final class KafkaTopics { + private KafkaTopics() {} + + public static final String TRANSACTION_CREATED = "transaction.created"; + public static final String TRANSACTION_STATUS_UPDATED = "transaction.status.updated"; +} \ No newline at end of file diff --git a/src/main/java/com/yape/transaction/infrastructure/outbound/kafka/TransactionCreatedEvent.java b/src/main/java/com/yape/transaction/infrastructure/outbound/kafka/TransactionCreatedEvent.java new file mode 100644 index 0000000..4dfaa1f --- /dev/null +++ b/src/main/java/com/yape/transaction/infrastructure/outbound/kafka/TransactionCreatedEvent.java @@ -0,0 +1,14 @@ +package com.yape.transaction.infrastructure.outbound.kafka; + +import java.math.BigDecimal; +import java.time.Instant; +import java.util.UUID; + +public record TransactionCreatedEvent( + UUID transactionExternalId, + UUID accountExternalIdDebit, + UUID accountExternalIdCredit, + Integer tranferTypeId, + BigDecimal value, + Instant createdAt +) {} \ No newline at end of file diff --git a/src/main/java/com/yape/transaction/infrastructure/outbound/kafka/TransactionEventProducer.java b/src/main/java/com/yape/transaction/infrastructure/outbound/kafka/TransactionEventProducer.java new file mode 100644 index 0000000..80dadc4 --- /dev/null +++ b/src/main/java/com/yape/transaction/infrastructure/outbound/kafka/TransactionEventProducer.java @@ -0,0 +1,35 @@ +package com.yape.transaction.infrastructure.outbound.kafka; + +import com.yape.transaction.domain.model.Transaction; +import com.yape.transaction.domain.port.TransactionEventPublisherPort; +import org.springframework.kafka.core.KafkaTemplate; +import org.springframework.stereotype.Component; + +@Component +public class TransactionEventProducer implements TransactionEventPublisherPort { + + private final KafkaTemplate kafkaTemplate; + + public TransactionEventProducer(KafkaTemplate kafkaTemplate) { + this.kafkaTemplate = kafkaTemplate; + } + + @Override + public void publishTransactionCreated(Transaction transaction) { + TransactionCreatedEvent event = new TransactionCreatedEvent( + transaction.getId(), + transaction.getAccountExternalIdDebit(), + transaction.getAccountExternalIdCredit(), + mapTypeId(transaction), + transaction.getValue(), + transaction.getCreatedAt() + ); + + kafkaTemplate.send(KafkaTopics.TRANSACTION_CREATED, transaction.getId().toString(), event); + } + + private Integer mapTypeId(Transaction transaction) { + // TRANSFER = 1 + return 1; + } +} diff --git a/src/main/java/com/yape/transaction/infrastructure/outbound/persistence/TransactionEntity.java b/src/main/java/com/yape/transaction/infrastructure/outbound/persistence/TransactionEntity.java new file mode 100644 index 0000000..6e1eb35 --- /dev/null +++ b/src/main/java/com/yape/transaction/infrastructure/outbound/persistence/TransactionEntity.java @@ -0,0 +1,64 @@ +package com.yape.transaction.infrastructure.outbound.persistence; + +import com.yape.transaction.domain.model.TransactionStatus; +import com.yape.transaction.domain.model.TransactionType; +import jakarta.persistence.*; + +import java.math.BigDecimal; +import java.time.Instant; +import java.util.UUID; + +@Entity +@Table(name = "transactions") +public class TransactionEntity { + + @Id + private UUID id; + + @Column(nullable = false) + private UUID accountExternalIdDebit; + + @Column(nullable = false) + private UUID accountExternalIdCredit; + + @Enumerated(EnumType.STRING) + @Column(nullable = false) + private TransactionType type; + + @Enumerated(EnumType.STRING) + @Column(nullable = false) + private TransactionStatus status; + + @Column(nullable = false) + private BigDecimal value; + + @Column(nullable = false) + private Instant createdAt; + + protected TransactionEntity() { + } + + public TransactionEntity(UUID id, + UUID debit, + UUID credit, + TransactionType type, + TransactionStatus status, + BigDecimal value, + Instant createdAt) { + this.id = id; + this.accountExternalIdDebit = debit; + this.accountExternalIdCredit = credit; + this.type = type; + this.status = status; + this.value = value; + this.createdAt = createdAt; + } + + public UUID getId() { return id; } + public UUID getAccountExternalIdDebit() { return accountExternalIdDebit; } + public UUID getAccountExternalIdCredit() { return accountExternalIdCredit; } + public TransactionType getType() { return type; } + public TransactionStatus getStatus() { return status; } + public BigDecimal getValue() { return value; } + public Instant getCreatedAt() { return createdAt; } +} diff --git a/src/main/java/com/yape/transaction/infrastructure/outbound/persistence/TransactionJpaRepository.java b/src/main/java/com/yape/transaction/infrastructure/outbound/persistence/TransactionJpaRepository.java new file mode 100644 index 0000000..835266f --- /dev/null +++ b/src/main/java/com/yape/transaction/infrastructure/outbound/persistence/TransactionJpaRepository.java @@ -0,0 +1,8 @@ +package com.yape.transaction.infrastructure.outbound.persistence; + +import org.springframework.data.jpa.repository.JpaRepository; + +import java.util.UUID; + +public interface TransactionJpaRepository extends JpaRepository { +} diff --git a/src/main/java/com/yape/transaction/infrastructure/outbound/persistence/TransactionRepositoryAdapter.java b/src/main/java/com/yape/transaction/infrastructure/outbound/persistence/TransactionRepositoryAdapter.java new file mode 100644 index 0000000..4e6465e --- /dev/null +++ b/src/main/java/com/yape/transaction/infrastructure/outbound/persistence/TransactionRepositoryAdapter.java @@ -0,0 +1,55 @@ +package com.yape.transaction.infrastructure.outbound.persistence; + +import com.yape.transaction.domain.model.Transaction; +import com.yape.transaction.domain.port.TransactionRepositoryPort; +import org.springframework.stereotype.Repository; + +import java.util.Optional; +import java.util.UUID; + +@Repository +public class TransactionRepositoryAdapter implements TransactionRepositoryPort { + + private final TransactionJpaRepository jpaRepository; + + public TransactionRepositoryAdapter(TransactionJpaRepository jpaRepository) { + this.jpaRepository = jpaRepository; + } + + @Override + public Transaction save(Transaction transaction) { + TransactionEntity entity = toEntity(transaction); + TransactionEntity saved = jpaRepository.save(entity); + return toDomain(saved); + } + + @Override + public Optional findById(UUID transactionId) { + return jpaRepository.findById(transactionId) + .map(this::toDomain); + } + + private TransactionEntity toEntity(Transaction tx) { + return new TransactionEntity( + tx.getId(), + tx.getAccountExternalIdDebit(), + tx.getAccountExternalIdCredit(), + tx.getType(), + tx.getStatus(), + tx.getValue(), + tx.getCreatedAt() + ); + } + + private Transaction toDomain(TransactionEntity entity) { + return new Transaction( + entity.getId(), + entity.getAccountExternalIdDebit(), + entity.getAccountExternalIdCredit(), + entity.getType(), + entity.getValue(), + entity.getStatus(), + entity.getCreatedAt() + ); + } +} diff --git a/src/main/resources/application.yml b/src/main/resources/application.yml new file mode 100644 index 0000000..13080b8 --- /dev/null +++ b/src/main/resources/application.yml @@ -0,0 +1,28 @@ +server: + port: 8080 + +spring: + datasource: + url: ${SPRING_DATASOURCE_URL:jdbc:postgresql://localhost:5432/transactionsdb} + username: ${SPRING_DATASOURCE_USERNAME:postgres} + password: ${SPRING_DATASOURCE_PASSWORD:postgres} + driver-class-name: org.postgresql.Driver + + jpa: + hibernate: + ddl-auto: update + show-sql: false + open-in-view: false + properties: + hibernate: + format_sql: true + jdbc: + time_zone: UTC + + kafka: + bootstrap-servers: ${SPRING_KAFKA_BOOTSTRAP_SERVERS:localhost:9092} + consumer: + key-deserializer: org.apache.kafka.common.serialization.StringDeserializer + value-deserializer: org.apache.kafka.common.serialization.StringDeserializer + auto-offset-reset: latest + diff --git a/src/test/java/com/yape/transaction/MainApplicationTests.java b/src/test/java/com/yape/transaction/MainApplicationTests.java new file mode 100644 index 0000000..54e9105 --- /dev/null +++ b/src/test/java/com/yape/transaction/MainApplicationTests.java @@ -0,0 +1,11 @@ +package com.yape.transaction; + +import org.junit.jupiter.api.Test; + +class MainApplicationTests { + + @Test + void contextLoads() { + } + +} diff --git a/src/test/java/com/yape/transaction/application/service/TransactionServiceTest.java b/src/test/java/com/yape/transaction/application/service/TransactionServiceTest.java new file mode 100644 index 0000000..5c580a0 --- /dev/null +++ b/src/test/java/com/yape/transaction/application/service/TransactionServiceTest.java @@ -0,0 +1,259 @@ +package com.yape.transaction.application.service; + +import com.yape.transaction.application.dto.CreateTransactionCommand; +import com.yape.transaction.application.dto.TransactionView; +import com.yape.transaction.domain.model.Transaction; +import com.yape.transaction.domain.model.TransactionStatus; +import com.yape.transaction.domain.model.TransactionType; +import com.yape.transaction.domain.port.TransactionEventPublisherPort; +import com.yape.transaction.domain.port.TransactionRepositoryPort; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; +import org.mockito.ArgumentCaptor; + +import java.math.BigDecimal; +import java.time.Instant; +import java.util.Optional; +import java.util.UUID; + +import static org.assertj.core.api.Assertions.*; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.Mockito.*; + +class TransactionServiceTest { + + private TransactionRepositoryPort repository; + private TransactionEventPublisherPort publisher; + private TransactionService service; + + @BeforeEach + void setUp() { + repository = mock(TransactionRepositoryPort.class); + publisher = mock(TransactionEventPublisherPort.class); + service = new TransactionService(repository, publisher); + } + + @Test + void create_shouldCreateSavePublishAndReturnId() { + // Given + UUID debit = UUID.randomUUID(); + UUID credit = UUID.randomUUID(); + Integer transferTypeId = 1; + BigDecimal value = new BigDecimal("10.50"); + + CreateTransactionCommand command = new CreateTransactionCommand( + debit, credit, transferTypeId, value + ); + + + when(repository.save(any(Transaction.class))) + .thenAnswer(inv -> inv.getArgument(0)); + + ArgumentCaptor txCaptor = ArgumentCaptor.forClass(Transaction.class); + + // When + UUID result = service.create(command); + + // Then + assertThat(result).isNotNull(); + + verify(repository).save(txCaptor.capture()); + Transaction savedTx = txCaptor.getValue(); + + assertThat(savedTx).isNotNull(); + assertThat(savedTx.getId()).isEqualTo(result); + assertThat(savedTx.getAccountExternalIdDebit()).isEqualTo(debit); + assertThat(savedTx.getAccountExternalIdCredit()).isEqualTo(credit); + assertThat(savedTx.getType()).isEqualTo(TransactionType.TRANSFER); + assertThat(savedTx.getValue()).isEqualByComparingTo(value); + assertThat(savedTx.getStatus()).isEqualTo(TransactionStatus.PENDING); + assertThat(savedTx.getCreatedAt()).isNotNull(); + + verify(publisher).publishTransactionCreated(savedTx); + verifyNoMoreInteractions(publisher); + } + + @Test + @DisplayName("create: should throw IllegalArgumentException when tranferTypeId is null") + void create_shouldThrowWhenTransferTypeIdIsNull() { + // Given + CreateTransactionCommand command = new CreateTransactionCommand( + UUID.randomUUID(), + UUID.randomUUID(), + null, + new BigDecimal("1.00") + ); + + // When + Throwable thrown = catchThrowable(() -> service.create(command)); + + // Then + assertThat(thrown) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage("tranferTypeId is required"); + + verifyNoInteractions(repository); + verifyNoInteractions(publisher); + } + + @Test + @DisplayName("create: should throw IllegalArgumentException when tranferTypeId is unsupported") + void create_shouldThrowWhenTransferTypeIdUnsupported() { + // Given + CreateTransactionCommand command = new CreateTransactionCommand( + UUID.randomUUID(), + UUID.randomUUID(), + 4, + new BigDecimal("1.00") + ); + + // When + Throwable thrown = catchThrowable(() -> service.create(command)); + + // Then + assertThat(thrown) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage("Unsupported tranferTypeId: 4"); + + verifyNoInteractions(repository); + verifyNoInteractions(publisher); + } + + @Test + @DisplayName("getById: should return TransactionView when transaction exists") + void getById_shouldReturnViewWhenExists() { + // Given + UUID id = UUID.randomUUID(); + UUID debit = UUID.randomUUID(); + UUID credit = UUID.randomUUID(); + BigDecimal value = new BigDecimal("20.00"); + Instant createdAt = Instant.parse("2025-12-29T00:00:00Z"); + + Transaction tx = new Transaction( + id, + debit, + credit, + TransactionType.TRANSFER, + value, + TransactionStatus.APPROVED, + createdAt + ); + + when(repository.findById(id)).thenReturn(Optional.of(tx)); + + // When + TransactionView view = service.getById(id); + + // Then + assertThat(view).isNotNull(); + assertThat(view.transactionExternalId()).isEqualTo(id); + assertThat(view.transactionTypeName()).isEqualTo(TransactionType.TRANSFER.name()); + assertThat(view.transactionStatusName()).isEqualTo(TransactionStatus.APPROVED.name()); + assertThat(view.value()).isEqualByComparingTo(value); + assertThat(view.createdAt()).isEqualTo(createdAt); + + verify(repository).findById(id); + verifyNoInteractions(publisher); + } + + @Test + @DisplayName("getById: should throw IllegalArgumentException when transaction does not exist") + void getById_shouldThrowWhenNotFound() { + // Given + UUID id = UUID.randomUUID(); + when(repository.findById(id)).thenReturn(Optional.empty()); + + // When + Throwable thrown = catchThrowable(() -> service.getById(id)); + + // Then + assertThat(thrown) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage("Transaction not found: " + id); + + verify(repository).findById(id); + verifyNoInteractions(publisher); + } + + @Test + @DisplayName("updateStatus: should update status and save transaction when found (case-insensitive)") + void updateStatus_shouldUpdateAndSaveWhenFound() { + // Given + UUID id = UUID.randomUUID(); + + Transaction tx = new Transaction( + id, + UUID.randomUUID(), + UUID.randomUUID(), + TransactionType.TRANSFER, + new BigDecimal("5.00"), + TransactionStatus.PENDING, + Instant.parse("2025-12-29T00:00:00Z") + ); + + when(repository.findById(id)).thenReturn(Optional.of(tx)); + when(repository.save(any(Transaction.class))).thenAnswer(inv -> inv.getArgument(0)); + + // When + service.updateStatus(id, "approved"); // minúsculas para validar upperCase() + + // Then + assertThat(tx.getStatus()).isEqualTo(TransactionStatus.APPROVED); + + verify(repository).findById(id); + verify(repository).save(tx); + verifyNoInteractions(publisher); + } + + @Test + @DisplayName("updateStatus: should throw IllegalArgumentException when transaction does not exist") + void updateStatus_shouldThrowWhenNotFound() { + // Given + UUID id = UUID.randomUUID(); + when(repository.findById(id)).thenReturn(Optional.empty()); + + // When + Throwable thrown = catchThrowable(() -> service.updateStatus(id, "APPROVED")); + + // Then + assertThat(thrown) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage("Transaction not found: " + id); + + verify(repository).findById(id); + verifyNoMoreInteractions(repository); + verifyNoInteractions(publisher); + } + + @Test + @DisplayName("updateStatus: throw IllegalArgumentException when newStatus is invalid") + void updateStatus_shouldThrowWhenStatusInvalid() { + // Given + UUID id = UUID.randomUUID(); + + Transaction tx = new Transaction( + id, + UUID.randomUUID(), + UUID.randomUUID(), + TransactionType.TRANSFER, + new BigDecimal("5.00"), + TransactionStatus.PENDING, + Instant.parse("2025-12-29T00:00:00Z") + ); + + when(repository.findById(id)).thenReturn(Optional.of(tx)); + + // When + Throwable thrown = catchThrowable(() -> service.updateStatus(id, "NOT_A_REAL_STATUS")); + + // Then + assertThat(thrown) + .isInstanceOf(IllegalArgumentException.class); + + + verify(repository).findById(id); + verify(repository, never()).save(any(Transaction.class)); + verifyNoInteractions(publisher); + } +} diff --git a/src/test/java/com/yape/transaction/domain/model/TransactionTest.java b/src/test/java/com/yape/transaction/domain/model/TransactionTest.java new file mode 100644 index 0000000..39b94ec --- /dev/null +++ b/src/test/java/com/yape/transaction/domain/model/TransactionTest.java @@ -0,0 +1,108 @@ +package com.yape.transaction.domain.model; + +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; + +import java.math.BigDecimal; +import java.util.UUID; + +import static org.assertj.core.api.Assertions.*; + +class TransactionTest { + + @Test + @DisplayName("createPending: should create transaction with PENDING status and generated id/createdAt") + void createPending_shouldCreatePendingTransaction() { + // Given + UUID debit = UUID.randomUUID(); + UUID credit = UUID.randomUUID(); + BigDecimal value = new BigDecimal("10.00"); + + // When + Transaction tx = Transaction.createPending(debit, credit, TransactionType.TRANSFER, value); + + // Then + assertThat(tx).isNotNull(); + assertThat(tx.getId()).isNotNull(); + assertThat(tx.getAccountExternalIdDebit()).isEqualTo(debit); + assertThat(tx.getAccountExternalIdCredit()).isEqualTo(credit); + assertThat(tx.getType()).isEqualTo(TransactionType.TRANSFER); + assertThat(tx.getValue()).isEqualByComparingTo(value); + assertThat(tx.getStatus()).isEqualTo(TransactionStatus.PENDING); + assertThat(tx.getCreatedAt()).isNotNull(); + } + + @Test + @DisplayName("updateStatus: should throw IllegalArgumentException when newStatus is null") + void updateStatus_shouldThrowWhenNull() { + // Given + Transaction tx = Transaction.createPending( + UUID.randomUUID(), + UUID.randomUUID(), + TransactionType.TRANSFER, + new BigDecimal("1.00") + ); + + // When + Throwable thrown = catchThrowable(() -> tx.updateStatus(null)); + + // Then + assertThat(thrown) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage("status is required"); + } + + @Test + @DisplayName("updateStatus: should update status when valid") + void updateStatus_shouldUpdate() { + // Given + Transaction tx = Transaction.createPending( + UUID.randomUUID(), + UUID.randomUUID(), + TransactionType.TRANSFER, + new BigDecimal("1.00") + ); + + // When + tx.updateStatus(TransactionStatus.APPROVED); + + // Then + assertThat(tx.getStatus()).isEqualTo(TransactionStatus.APPROVED); + } + + @Test + @DisplayName("approve: should set status to APPROVED") + void approve_shouldSetApproved() { + // Given + Transaction tx = Transaction.createPending( + UUID.randomUUID(), + UUID.randomUUID(), + TransactionType.TRANSFER, + new BigDecimal("1.00") + ); + + // When + tx.approve(); + + // Then + assertThat(tx.getStatus()).isEqualTo(TransactionStatus.APPROVED); + } + + @Test + @DisplayName("reject: should set status to REJECTED") + void reject_shouldSetRejected() { + // Given + Transaction tx = Transaction.createPending( + UUID.randomUUID(), + UUID.randomUUID(), + TransactionType.TRANSFER, + new BigDecimal("1.00") + ); + + // When + tx.reject(); + + // Then + assertThat(tx.getStatus()).isEqualTo(TransactionStatus.REJECTED); + } +} diff --git a/src/test/java/com/yape/transaction/infrastructure/inbound/kafka/TransactionStatusUpdatedConsumerTest.java b/src/test/java/com/yape/transaction/infrastructure/inbound/kafka/TransactionStatusUpdatedConsumerTest.java new file mode 100644 index 0000000..addee70 --- /dev/null +++ b/src/test/java/com/yape/transaction/infrastructure/inbound/kafka/TransactionStatusUpdatedConsumerTest.java @@ -0,0 +1,64 @@ +package com.yape.transaction.infrastructure.inbound.kafka; + +import com.fasterxml.jackson.databind.ObjectMapper; +import com.yape.transaction.application.usecase.UpdateTransactionStatusUseCase; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; + +import java.util.UUID; + +import static org.mockito.Mockito.*; + +class TransactionStatusUpdatedConsumerTest { + + private UpdateTransactionStatusUseCase useCase; + private ObjectMapper objectMapper; + private TransactionStatusUpdatedConsumer consumer; + + @BeforeEach + void setUp() { + // Given + useCase = mock(UpdateTransactionStatusUseCase.class); + objectMapper = mock(ObjectMapper.class); + consumer = new TransactionStatusUpdatedConsumer(useCase, objectMapper); + } + + @Test + @DisplayName("onMessage: process valid message") + void onMessage_shouldCallUseCaseWhenMessageValid() throws Exception { + // Given + UUID txId = UUID.randomUUID(); + String status = "APPROVED"; + String message = "{\"transactionExternalId\":\"" + txId + "\",\"status\":\"" + status + "\"}"; + + TransactionStatusUpdatedEvent event = new TransactionStatusUpdatedEvent(txId, status); + when(objectMapper.readValue(message, TransactionStatusUpdatedEvent.class)).thenReturn(event); + + // When + consumer.onMessage(message); + + // Then + verify(useCase).updateStatus(txId, status); + verifyNoMoreInteractions(useCase); + verify(objectMapper).readValue(message, TransactionStatusUpdatedEvent.class); + verifyNoMoreInteractions(objectMapper); + } + + @Test + @DisplayName("onMessage: ignore invalid message") + void onMessage_shouldNotThrowAndNotCallUseCaseWhenInvalidJson() throws Exception { + // Given + String message = "invalid-json"; + when(objectMapper.readValue(message, TransactionStatusUpdatedEvent.class)) + .thenThrow(new RuntimeException("boom")); + + // When + consumer.onMessage(message); + + // Then + verifyNoInteractions(useCase); + verify(objectMapper).readValue(message, TransactionStatusUpdatedEvent.class); + verifyNoMoreInteractions(objectMapper); + } +} diff --git a/src/test/java/com/yape/transaction/infrastructure/inbound/rest/TransactionControllerTest.java b/src/test/java/com/yape/transaction/infrastructure/inbound/rest/TransactionControllerTest.java new file mode 100644 index 0000000..27a0090 --- /dev/null +++ b/src/test/java/com/yape/transaction/infrastructure/inbound/rest/TransactionControllerTest.java @@ -0,0 +1,180 @@ +package com.yape.transaction.infrastructure.inbound.rest; + +import com.yape.transaction.application.dto.TransactionView; +import com.yape.transaction.application.usecase.CreateTransactionUseCase; +import com.yape.transaction.application.usecase.GetTransactionUseCase; +import com.yape.transaction.infrastructure.inbound.rest.exception.ApiExceptionHandler; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; +import org.mockito.Mockito; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.beans.factory.annotation.Qualifier; +import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest; +import org.springframework.boot.test.context.TestConfiguration; +import org.springframework.context.annotation.Bean; +import org.springframework.context.annotation.Import; +import org.springframework.http.MediaType; +import org.springframework.test.web.servlet.MockMvc; + +import java.math.BigDecimal; +import java.time.Instant; +import java.util.UUID; + +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.eq; +import static org.mockito.Mockito.*; +import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get; +import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post; +import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*; + +@WebMvcTest(controllers = TransactionController.class) +@Import({ApiExceptionHandler.class, TransactionControllerTest.TestConfig.class}) +class TransactionControllerTest { + + @Autowired + MockMvc mockMvc; + + @Autowired + @Qualifier("createTransactionUseCase") + private CreateTransactionUseCase createUseCase; + + @Autowired + @Qualifier("getTransactionUseCase") + private GetTransactionUseCase getUseCase; + + + @TestConfiguration + static class TestConfig { + + @Bean("createTransactionUseCase") + CreateTransactionUseCase createTransactionUseCase() { + return Mockito.mock(CreateTransactionUseCase.class); + } + + @Bean("getTransactionUseCase") + GetTransactionUseCase getTransactionUseCase() { + return Mockito.mock(GetTransactionUseCase.class); + } + } + + @BeforeEach + public void resetMocks() { + reset(createUseCase, getUseCase); + } + + + @Test + @DisplayName("POST /transactions: created") + void create_shouldReturn201WhenValid() throws Exception { + // Given + UUID txId = UUID.randomUUID(); + when(createUseCase.create(any())).thenReturn(txId); + + UUID debit = UUID.randomUUID(); + UUID credit = UUID.randomUUID(); + + String json = """ + { + "accountExternalIdDebit": "%s", + "accountExternalIdCredit": "%s", + "tranferTypeId": 1, + "value": 10.50 + } + """.formatted(debit, credit); + + // When / Then + mockMvc.perform(post("/transactions") + .contentType(MediaType.APPLICATION_JSON) + .content(json)) + .andExpect(status().isCreated()) + .andExpect(content().contentTypeCompatibleWith(MediaType.APPLICATION_JSON)) + .andExpect(jsonPath("$.transactionExternalId").value(txId.toString())); + + verify(createUseCase).create(any()); + verifyNoMoreInteractions(createUseCase); + verifyNoInteractions(getUseCase); + } + + @Test + @DisplayName("POST /transactions: bad request") + void create_shouldReturn400WhenInvalid() throws Exception { + // Given + UUID debit = UUID.randomUUID(); + UUID credit = UUID.randomUUID(); + + String json = """ + { + "accountExternalIdDebit": "%s", + "accountExternalIdCredit": "%s", + "tranferTypeId": 1, + "value": 0.00 + } + """.formatted(debit, credit); + + // When + // Then + mockMvc.perform(post("/transactions") + .contentType(MediaType.APPLICATION_JSON) + .content(json)) + .andExpect(status().isBadRequest()) + .andExpect(content().contentTypeCompatibleWith(MediaType.APPLICATION_JSON)) + .andExpect(jsonPath("$.message").value("Solicitud inválida")); + + verifyNoInteractions(createUseCase); + verifyNoInteractions(getUseCase); + } + + @Test + @DisplayName("GET /transactions/{id}: success") + void get_shouldReturn200WhenFound() throws Exception { + // Given + UUID id = UUID.randomUUID(); + + TransactionView view = new TransactionView( + id, + "TRANSFER", + "APPROVED", + new BigDecimal("25.00"), + Instant.parse("2025-12-29T00:00:00Z") + ); + + when(getUseCase.getById(eq(id))).thenReturn(view); + + // When + // Then + mockMvc.perform(get("/transactions/{transactionExternalId}", id)) + .andExpect(status().isOk()) + .andExpect(content().contentTypeCompatibleWith(MediaType.APPLICATION_JSON)) + + .andExpect(jsonPath("$.transactionExternalId").value(id.toString())) + .andExpect(jsonPath("$.transactionType.name").value("TRANSFER")) + .andExpect(jsonPath("$.transactionStatus.name").value("APPROVED")) + .andExpect(jsonPath("$.value").value(25.00)) + .andExpect(jsonPath("$.createdAt").value("2025-12-29T00:00:00Z")); + + verify(getUseCase).getById(id); + verifyNoMoreInteractions(getUseCase); + verifyNoInteractions(createUseCase); + } + + @Test + @DisplayName("GET /transactions/{id}: internal server error") + void get_shouldReturn500WhenUseCaseThrows() throws Exception { + // Given + UUID id = UUID.randomUUID(); + when(getUseCase.getById(eq(id))).thenThrow(new IllegalArgumentException("Transaction not found: " + id)); + + // When + // Then + + mockMvc.perform(get("/transactions/{transactionExternalId}", id)) + .andExpect(status().isInternalServerError()) + .andExpect(content().contentTypeCompatibleWith(MediaType.APPLICATION_JSON)) + .andExpect(jsonPath("$.message").value("Error interno del servidor")); + + verify(getUseCase).getById(id); + verifyNoMoreInteractions(getUseCase); + verifyNoInteractions(createUseCase); + } +} diff --git a/src/test/java/com/yape/transaction/infrastructure/outbound/kafka/TransactionEventProducerTest.java b/src/test/java/com/yape/transaction/infrastructure/outbound/kafka/TransactionEventProducerTest.java new file mode 100644 index 0000000..50ab41c --- /dev/null +++ b/src/test/java/com/yape/transaction/infrastructure/outbound/kafka/TransactionEventProducerTest.java @@ -0,0 +1,80 @@ +package com.yape.transaction.infrastructure.outbound.kafka; + +import com.yape.transaction.domain.model.Transaction; +import com.yape.transaction.domain.model.TransactionStatus; +import com.yape.transaction.domain.model.TransactionType; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; +import org.mockito.ArgumentCaptor; +import org.springframework.kafka.core.KafkaTemplate; + +import java.math.BigDecimal; +import java.time.Instant; +import java.util.UUID; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.mockito.Mockito.*; + +class TransactionEventProducerTest { + + private KafkaTemplate kafkaTemplate; + private TransactionEventProducer producer; + + @BeforeEach + void setUp() { + // Given + kafkaTemplate = mock(KafkaTemplate.class); + producer = new TransactionEventProducer(kafkaTemplate); + } + + @Test + @DisplayName("Send TransactionCreatedEvent to correct topic with correct key and payload") + void publishTransactionCreated_shouldSendEventToKafka() { + // Given + UUID id = UUID.randomUUID(); + UUID debit = UUID.randomUUID(); + UUID credit = UUID.randomUUID(); + BigDecimal value = new BigDecimal("15.00"); + Instant createdAt = Instant.parse("2025-12-29T00:00:00Z"); + + Transaction transaction = new Transaction( + id, + debit, + credit, + TransactionType.TRANSFER, + value, + TransactionStatus.PENDING, + createdAt + ); + + ArgumentCaptor topicCaptor = ArgumentCaptor.forClass(String.class); + ArgumentCaptor keyCaptor = ArgumentCaptor.forClass(String.class); + ArgumentCaptor payloadCaptor = ArgumentCaptor.forClass(Object.class); + + // When + producer.publishTransactionCreated(transaction); + + // Then + verify(kafkaTemplate).send( + topicCaptor.capture(), + keyCaptor.capture(), + payloadCaptor.capture() + ); + + assertThat(topicCaptor.getValue()).isEqualTo(KafkaTopics.TRANSACTION_CREATED); + assertThat(keyCaptor.getValue()).isEqualTo(id.toString()); + + assertThat(payloadCaptor.getValue()).isInstanceOf(TransactionCreatedEvent.class); + TransactionCreatedEvent event = (TransactionCreatedEvent) payloadCaptor.getValue(); + + assertThat(event.transactionExternalId()).isEqualTo(id); + assertThat(event.accountExternalIdDebit()).isEqualTo(debit); + assertThat(event.accountExternalIdCredit()).isEqualTo(credit); + assertThat(event.tranferTypeId()).isEqualTo(1); // TRANSFER = 1 + assertThat(event.value()).isEqualByComparingTo(value); + assertThat(event.createdAt()).isEqualTo(createdAt); + + verifyNoMoreInteractions(kafkaTemplate); + } +} diff --git a/src/test/java/com/yape/transaction/infrastructure/outbound/persistence/TransactionRepositoryAdapterTest.java b/src/test/java/com/yape/transaction/infrastructure/outbound/persistence/TransactionRepositoryAdapterTest.java new file mode 100644 index 0000000..d56f49b --- /dev/null +++ b/src/test/java/com/yape/transaction/infrastructure/outbound/persistence/TransactionRepositoryAdapterTest.java @@ -0,0 +1,122 @@ +package com.yape.transaction.infrastructure.outbound.persistence; + +import com.yape.transaction.domain.model.Transaction; +import com.yape.transaction.domain.model.TransactionStatus; +import com.yape.transaction.domain.model.TransactionType; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; + +import java.math.BigDecimal; +import java.time.Instant; +import java.util.Optional; +import java.util.UUID; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.mockito.Mockito.*; + +class TransactionRepositoryAdapterTest { + + private TransactionJpaRepository jpaRepository; + private TransactionRepositoryAdapter adapter; + + @BeforeEach + void setUp() { + // Given + jpaRepository = mock(TransactionJpaRepository.class); + adapter = new TransactionRepositoryAdapter(jpaRepository); + } + + @Test + @DisplayName("save: should map domain to entity, persist, and map back to domain") + void save_shouldMapPersistAndMapBack() { + // Given + UUID id = UUID.randomUUID(); + UUID debit = UUID.randomUUID(); + UUID credit = UUID.randomUUID(); + BigDecimal value = new BigDecimal("10.00"); + Instant createdAt = Instant.parse("2025-12-29T00:00:00Z"); + + Transaction domain = new Transaction( + id, debit, credit, + TransactionType.TRANSFER, + value, + TransactionStatus.PENDING, + createdAt + ); + + TransactionEntity persisted = new TransactionEntity( + id, debit, credit, + TransactionType.TRANSFER, + TransactionStatus.PENDING, + value, + createdAt + ); + + when(jpaRepository.save(any(TransactionEntity.class))).thenReturn(persisted); + + // When + Transaction result = adapter.save(domain); + + // Then + assertThat(result).isNotNull(); + assertThat(result.getId()).isEqualTo(id); + assertThat(result.getAccountExternalIdDebit()).isEqualTo(debit); + assertThat(result.getAccountExternalIdCredit()).isEqualTo(credit); + assertThat(result.getType()).isEqualTo(TransactionType.TRANSFER); + assertThat(result.getStatus()).isEqualTo(TransactionStatus.PENDING); + assertThat(result.getValue()).isEqualByComparingTo(value); + assertThat(result.getCreatedAt()).isEqualTo(createdAt); + + verify(jpaRepository).save(any(TransactionEntity.class)); + verifyNoMoreInteractions(jpaRepository); + } + + @Test + @DisplayName("findById: should return mapped domain when entity exists") + void findById_shouldReturnDomainWhenExists() { + // Given + UUID id = UUID.randomUUID(); + TransactionEntity entity = new TransactionEntity( + id, + UUID.randomUUID(), + UUID.randomUUID(), + TransactionType.TRANSFER, + TransactionStatus.APPROVED, + new BigDecimal("20.00"), + Instant.parse("2025-12-29T00:00:00Z") + ); + + when(jpaRepository.findById(id)).thenReturn(Optional.of(entity)); + + // When + Optional result = adapter.findById(id); + + // Then + assertThat(result).isPresent(); + assertThat(result.get().getId()).isEqualTo(entity.getId()); + assertThat(result.get().getType()).isEqualTo(entity.getType()); + assertThat(result.get().getStatus()).isEqualTo(entity.getStatus()); + assertThat(result.get().getValue()).isEqualByComparingTo(entity.getValue()); + assertThat(result.get().getCreatedAt()).isEqualTo(entity.getCreatedAt()); + + verify(jpaRepository).findById(id); + verifyNoMoreInteractions(jpaRepository); + } + + @Test + @DisplayName("findById: should return empty when entity does not exist") + void findById_shouldReturnEmptyWhenNotFound() { + // Given + UUID id = UUID.randomUUID(); + when(jpaRepository.findById(id)).thenReturn(Optional.empty()); + + // When + Optional result = adapter.findById(id); + + // Then + assertThat(result).isEmpty(); + verify(jpaRepository).findById(id); + verifyNoMoreInteractions(jpaRepository); + } +}