Add observedGeneration field to status of postgresql resource #3006
+59
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkeloscar
added
major
mikkeloscar
force-pushed
the
use-update-status
branch
from
e006b9a to
fffb532
Compare
mikkeloscar
force-pushed
the
observed-generation
branch
2 times, most recently
from
8cdc982 to
dbea3a5
Compare
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
mikkeloscar
force-pushed
the
observed-generation
branch
from
dbea3a5 to
8dc052e
Compare
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new status field
observedGenerationon thepostgresqlresource. The purpose of this is to correctly reflect when the postgres-operator has observed the resource change and applied the desired updates/changes on child resources.This is a standard pattern in Kubernetes where resources like
deploymentalso use this to indicate when the latest deployment spec has been processed.This change is especially helpful in deployment situation where the resource is applied and the deployment system checks if the resource is "ready". Without this the deployment system can't determine if the changes were already applied or not, assuming they were which can be wrong.
TODO