drivers: can: use proper namespace for driver-specific Kconfig symbols #100596
+145
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikbrixandersen
force-pushed
the
can_max_filters_kconfig
branch
from
f3d19c2 to
149b3dd
Compare
zephyrbot
requested review from
FRASTM,
Holt-Sun,
alexanderwachter,
bperseghetti,
etienne-lms,
jsbatch,
juickar,
manuargue,
martinjaeger,
mcatee-infineon,
nashif,
pdgendt,
str4t0m,
tpambor and
xakep-amatop
henrikbrixandersen
force-pushed
the
can_max_filters_kconfig
branch
from
149b3dd to
f0b9f09
Compare
alexanderwachter
previously approved these changes
Dec 5, 2025
martinjaeger
reviewed
Dec 6, 2025
Member
martinjaeger
left a comment
martinjaeger
left a comment
There was a problem hiding this comment.
Now that the Kconfig is changed anyway, should it not be plural? _MAX_FILTERS
henrikbrixandersen
force-pushed
the
can_max_filters_kconfig
branch
from
f0b9f09 to
471c01a
Compare
Use proper namespace for the CAN loopback driver Kconfig symbols, renaming CONFIG_CAN_MAX_FILTER to CONFIG_CAN_LOOPBACK_MAX_FILTERS. This prevents Kconfig symbol clashes between different CAN controller drivers. Signed-off-by: Henrik Brix Andersen <henrik@brixandersen.dk>
Use proper namespace for the CAN native_linux driver Kconfig symbols, renaming CONFIG_CAN_MAX_FILTER to CONFIG_CAN_NATIVE_LINUX_MAX_FILTERS. This prevents Kconfig symbol clashes between different CAN controller drivers. Signed-off-by: Henrik Brix Andersen <henrik@brixandersen.dk>
Use proper namespace for the CAN sja1000 Kconfig symbols, renaming CONFIG_CAN_MAX_FILTER to CONFIG_CAN_SJA1000_MAX_FILTERS. This prevents Kconfig symbol clashes between different CAN controller drivers. Signed-off-by: Henrik Brix Andersen <henrik@brixandersen.dk>
Use proper namespace for the CAN mcp2515 Kconfig symbols, renaming CONFIG_CAN_MAX_FILTER to CONFIG_CAN_MCP2515_MAX_FILTERS. This prevents Kconfig symbol clashes between different CAN controller drivers. Signed-off-by: Henrik Brix Andersen <henrik@brixandersen.dk>
Use proper namespace for the CAN max32 Kconfig symbols, renaming CONFIG_CAN_MAX_FILTER to CONFIG_CAN_MAX32_MAX_FILTERS. This prevents Kconfig symbol clashes between different CAN controller drivers. Signed-off-by: Henrik Brix Andersen <henrik@brixandersen.dk>
Use proper namespace for the CAN mcp251xfd Kconfig symbols, renaming CONFIG_CAN_MAX_FILTER to CONFIG_CAN_MCP251XFD_MAX_FILTERS. This prevents Kconfig symbol clashes between different CAN controller drivers. Signed-off-by: Henrik Brix Andersen <henrik@brixandersen.dk>
Use proper namespace for the MCUX FlexCAN Kconfig symbols, renaming CONFIG_CAN_MAX_FILTER to CONFIG_CAN_MCUX_FLEXCAN_MAX_FILTERS and CONFIG_CAN_MAX_MB to CONFIG_CAN_MCUX_FLEXCAN_MAX_MB. This prevents Kconfig symbol clashes between different CAN controller drivers. Signed-off-by: Henrik Brix Andersen <henrik@brixandersen.dk>
Use proper namespace for the STM32 bxCAN Kconfig symbols, renaming CONFIG_CAN_MAX_STD_ID_FILTER to CONFIG_CAN_STM32_BXCAN_MAX_STD_ID_FILTERS and CONFIG_CAN_MAX_EXT_ID_FILTER to CONFIG_CAN_STM32_BXCAN_MAX_EXT_ID_FILTERS. This prevents Kconfig symbol clashes between different CAN controller drivers. Signed-off-by: Henrik Brix Andersen <henrik@brixandersen.dk>
Use proper namespace for the STM32 FDCAN Kconfig symbols, renaming CONFIG_CAN_MAX_STD_ID_FILTER to CONFIG_CAN_STM32_FDCAN_MAX_STD_ID_FILTERS and CONFIG_CAN_MAX_EXT_ID_FILTER to CONFIG_CAN_STM32_FDCAN_MAX_EXT_ID_FILTERS. This prevents Kconfig symbol clashes between different CAN controller drivers. Signed-off-by: Henrik Brix Andersen <henrik@brixandersen.dk>
Use proper namespace for the CAN xmc4xxx Kconfig symbols, renaming CONFIG_CAN_MAX_FILTER to CONFIG_CAN_XMC4XXX_MAX_FILTERS. This prevents Kconfig symbol clashes between different CAN controller drivers. Signed-off-by: Henrik Brix Andersen <henrik@brixandersen.dk>
Rename Kconfig option CONFIG_CAN_RCAR_MAX_FILTER to CONFIG_CAN_RCAR_MAX_FILTERS to match remaining CAN driver Kconfig option naming. Signed-off-by: Henrik Brix Andersen <henrik@brixandersen.dk>
Increase the default number of software-limited CAN RX filters across the drivers. Some of these were chosen quite conservative, requiring custom configuration for even simple in-tree samples. Users can reduce the number of available RX filters to reduce RAM footprint as needed. Signed-off-by: Henrik Brix Andersen <henrik@brixandersen.dk>
henrikbrixandersen
force-pushed
the
can_max_filters_kconfig
branch
from
471c01a to
df0074f
Compare
Member
Author
Thanks! Yes, good idea - I've changed it. |
Remove setting of CONFIG_CAN_MAX_FILTER and rely on driver defaults. Signed-off-by: Henrik Brix Andersen <henrik@brixandersen.dk>
Mention the CAN controller driver Kconfig namespace changes in the migration guide. Signed-off-by: Henrik Brix Andersen <henrik@brixandersen.dk>
henrikbrixandersen
force-pushed
the
can_max_filters_kconfig
branch
from
df0074f to
5d04022
Compare
alexanderwachter
approved these changes
Dec 6, 2025
|
martinjaeger
approved these changes
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, quite a few CAN controller drivers define Kconfig symbols with identical names (e.g.
CONFIG_CAN_MAX_FILTER) but the ranges and defaults of these symbols differ between drivers, causing clashes and misconfigurations when multiple drivers are enabled concurrently.Rename these driver-specific Kconfig symbols to use proper namespacing and increase their defaults where needed to support typical software needs and in-tree samples.
This problem became evident with the reshuffling of the Kconfig.* include order in 30950b8.