feat: db account storage cleanup task #1296
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergerad
reviewed
Oct 17, 2025
| #[derive(Clone)] | ||
| pub struct Db { | ||
| pool: deadpool_diesel::Pool<ConnectionManager, deadpool::managed::Object<ConnectionManager>>, | ||
| notify_cleanup_task: tokio::sync::mpsc::Sender<BlockNumber>, |
Collaborator
There was a problem hiding this comment.
Depending on what we do with the validator database (whether we re-use this or not), it would be good to make this task optional/disable-able
This was referenced Oct 22, 2025
bobbinth
reviewed
Oct 23, 2025
Comment on lines
+950
to
+958
| // Strategy: For each vault_key, keep the latest entry (is_latest_update=true) and the | ||
| // most recent MAX_HISTORICAL_ENTRIES_PER_ACCOUNT historical entries, deleting the rest. | ||
| // | ||
| // Unfortunately, Diesel doesn't support window functions (ROW_NUMBER OVER) in its type-safe | ||
| // API, so we must use raw SQL for this complex deletion pattern. This is necessary because: | ||
| // 1. We need to partition by vault_key and order by block_num | ||
| // 2. We need to delete based on row ranking within each partition | ||
| // 3. The table is created WITHOUT ROWID, so we use the primary key (account_id, block_num, | ||
| // vault_key) |
Contributor
There was a problem hiding this comment.
I'm not sure we need to keep MAX_HISTORICAL_ENTRIES_PER_ACCOUNT - we just need to make sure we have the data for the last
DELETE FROM account_vault_assets
WHERE
block_num < chain_tip - n
AND is_latest_update = falseTo make this query efficient, we may need to add indexes on block_num and is_latest_update fields.
This methodology should also apply to the account_storage_map_values table (and in the future to the accounts table).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1185 step 5.