RPC omit errors when empty #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ToniRamirezM
approved these changes
Dec 3, 2024
goran-ethernal
approved these changes
Dec 3, 2024
vcastellm
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a successful response on the certain RPC function, the
errorfield (with nil value) is present in the JSON response. This causes issue with Foundry, when trying to deserialize it.Deserialization Error: invalid type: null, expected struct JsonRpcError at line 1 column 140. Response: {"jsonrpc":"2.0","id":1,"result":{"uptime":"6.547542578s","version":"v0.0.10-15-g5089d5c","key_count":0,"backfill_progress":94},"error":null}The same applies when there is an error, in that case, the response object should be omitted, instead of populating it with the
nilvalue.