Add JWT token option to S2SClient #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds JWT token authentication option to the S2SClient, allowing clients to provide a pre-generated JWT token as an alternative to generating one from a JWT secret. The change provides more flexibility in authentication methods while maintaining backward compatibility.
- Adds
JWTTokenfield toS2SClientConfigfor direct token authentication - Updates authorization logic to prioritize provided JWT token over secret-based generation
- Promotes several dependencies from indirect to direct in go.mod
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| s2s.go | Adds JWT token field and updates authentication logic to support both token and secret-based auth |
| go.mod | Promotes base64, base62, and cobra dependencies from indirect to direct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.