ethreceipts: receipt listener updates, and new QueryOnChain fetch fun… #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces improvements the
ethreceiptspackage in addition to adding newQueryOnChainfunction option which is called at the beginning of a subscriber registration. We already had this option for when we search QueryOnChainTxnHash, looking for a transaction hash, and now we've added a pluggable option.The reason we add this is so for example, Sequence v3 library can search for past meta txns via a eth_getLogs search for the CallsSucceeded topic. This is important because in the case that a receipt is past the window of the listener, then it can look further back before listening for new contents.
In addition, some minor other improvements have been made to
ethreceipts