-
Notifications
You must be signed in to change notification settings - Fork 7
V5 Ecosystem Wallet #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
V5 Ecosystem Wallet #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 0 address will be equal regardless of if they have the same value string (one may have more 0s than the other) - for example, previously 0x00 and 0x0000 would not be considered equal like they should've been, this is now fixed.
…andle either byte[] or FixedByte types
…han just BigIntegers; also, don't throw an ArgumentOutOfRangeException due to having a larger bigint than the desired size by clamping the padding to a min of 0
…tion tests are failing
…when trying to take a substring in FixedBytesCoder if we have our byte array ending with 0 values; instead, we should just leave them and take the substring as in the spec
…ign object from a ConfigUpdate Parented payload
…ign object from a Message Parented payload
…oSign from a Calls Parented Payload
…nderstand, adding some unit tests in the process.
…is is much cleaner to read
…pe) to the Nethereum equivalents
taylanpince
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version Increment
Please ensure you have incremented the package version in the package.json as necessary.
Docs Checklist
Please ensure you have addressed documentation updates if needed as part of this PR: