Reduce STV + Add Xcode tests #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1998code
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the Continuous Integration workflow to support multiple Xcode versions and downgrades the Swift tools version for improved compatibility with older environments. The key changes include:
- Adding new workflow jobs for Xcode 15.4, 15.0, and 14.3 alongside the renamed xcode-16-3 job.
- Downgrading the Swift tools version in Package.swift from 6.0 to 5.9.
- Updating the README.md to present platform and version information in a table format.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Reformatted table for supported platforms and version information. |
| Package.swift | Downgraded Swift tools version and commented out the test target. |
| .github/workflows/swift.yml | Added and renamed workflow jobs for multiple Xcode versions with test steps commented out. |
Comments suppressed due to low confidence (3)
Package.swift:26
- The testTarget for 'SwiftGlassTests' has been commented out. If the tests are intended to validate functionality, please re-enable them or provide a comment clarifying their removal.
.testTarget(
.github/workflows/swift.yml:23
- Test steps are commented out in the workflow jobs while the PR indicates an effort to add Xcode tests. Please confirm if tests should be re-enabled to maintain CI validation across multiple Xcode versions.
# - name: Test
README.md:47
- [nitpick] The Xcode row in the table uses an ambiguous header with an empty second column and 'SVT' as a heading. Consider using more explicit headers such as 'Latest Version', 'Minimum Version', and 'Swift Tools Version' for clarity.
| Xcode | | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the Swift project, including adjustments to workflows, compatibility changes, and documentation improvements. The most notable changes involve adding support for multiple Xcode versions in the CI workflow, downgrading the Swift tools version, and improving the
README.mdformatting for clarity.Workflow updates:
.github/workflows/swift.yml: Added separate jobs forxcode-16-3,xcode-15-4, andxcode-15-0to support multiple Xcode versions. Testing steps have been commented out for all jobs. [1] [2]Compatibility changes:
Package.swift: Downgraded the Swift tools version from6.0to5.9to align with broader compatibility.Package.swift: Commented out thetestTargetdefinition, effectively disabling tests for the package.Documentation improvements:
README.md: Reformatted the "Tested Platforms and Environment" section into a table for better readability. Added a table to clarify Xcode version requirements, including the latest, minimum, and Swift version tested (SVT).