Refactor Stellar support #99
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
added 2 commits
July 25, 2024 01:28
jzethar
commented
Jul 24, 2024
|
|
||
| // Getting balances from the node | ||
| // wtf what to do with it? | ||
| final public function api_get_balance(string $address, array $currencies): array |
Collaborator
Author
There was a problem hiding this comment.
@Har01d Due to the some PHP features we can't override two functions with the same name in one module without calling the rain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a unified module for Stellar, consolidating all operations and fees into a single event group. However, in my opinion, this approach is sub-optimal for working with Stellar. The primary concern is that processing blocks now requires significantly more time.