Fix deprecated API usages throughout the app #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses deprecated method calls identified in issue 5calls#159, updating them to use modern Android APIs compatible with the current minSdk (API 23+). ## Files Changed: **CustomTabsUtil.java** - Replaced deprecated `setToolbarColor(int)` with `setDefaultColorSchemeParams(CustomTabColorSchemeParams)` - Modern approach supports color schemes for light/dark mode - Smoketest: Open About screen, tap any web link buttons (About Us, Why Calling, Privacy, Dashboard). Chrome Custom Tabs should open with app's primary color in toolbar. **GridItemDecoration.java** - Replaced deprecated `getViewAdapterPosition()` with `getBindingAdapterPosition()` - Smoketest: Navigate to RepCallActivity, verify grid spacing displays correctly on outcome buttons. **IssueActivity.java** - Replaced deprecated `startActivityForResult()` with modern Activity Result API - Added `ActivityResultLauncher` and moved result handling to callback - Removed deprecated `onActivityResult()` method - Smoketest: Select an issue, tap on a representative row to launch RepCallActivity, navigate back and verify result handling works (especially server error state). **IssuesAdapter.java** - Replaced 3 instances of deprecated `getResources().getColor()` with `ContextCompat.getColor()` - Affects button icon tinting in empty state views - Smoketest: Trigger empty states (no internet for refresh button, no location for location button, no search match for search button). Verify colored icons display correctly. **NotifyBroadcastReceiver.java** - Replaced 3 deprecated `Notification.Action.Builder(int, CharSequence, PendingIntent)` constructors with modern `Icon.createWithResource()` approach - Replaced deprecated `getResources().getColor()` with `ContextCompat.getColor()` - Smoketest: Enable reminders in settings, wait for/trigger notification. Verify notification appears with Snooze, Settings, and Dismiss buttons with correct icons and primary color accent. **StatsActivity.java** - Replaced 9 instances of deprecated `getResources().getColor()` with `ContextCompat.getColor()` - Affects pie chart colors, line graph colors, grid colors, and text colors - Smoketest: Open Stats screen, verify pie chart displays with correct outcome colors (green/orange/gray) and line graph shows white grid lines with colored series. **MainActivity.java** - Replaced deprecated `getResources().getColor()` with `ContextCompat.getColor()` - Affects snackbar action button color - Smoketest: Enter a location/zip that splits congressional districts, verify snackbar appears with "UPDATE" button in accent light color. ## Notes: - OkHttpStack.java contains many deprecation warnings but is dead code (commented out in FiveCallsApi.java due to Samsung Galaxy device failures). Left untouched as it's never instantiated. - Optimized imports across modified files. Addresses 5calls#159
dektar
reviewed
Oct 23, 2025
Collaborator
dektar
left a comment
dektar
left a comment
There was a problem hiding this comment.
LG % one nit below. Thanks for the clean-up. I tried this on a Pixel XL running Android 10 and it's fine there, FWIW.
5calls/app/src/main/java/org/a5calls/android/a5calls/controller/IssueActivity.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses deprecated method calls identified in issue #159, updating them to use modern Android APIs compatible with the current minSdk (API 23+).
Files Changed:
CustomTabsUtil.java
setToolbarColor(int)withsetDefaultColorSchemeParams(CustomTabColorSchemeParams)GridItemDecoration.java
getViewAdapterPosition()withgetBindingAdapterPosition()IssueActivity.java
startActivityForResult()with modern Activity Result APIActivityResultLauncherand moved result handling to callbackonActivityResult()methodIssuesAdapter.java
getResources().getColor()withContextCompat.getColor()NotifyBroadcastReceiver.java
Notification.Action.Builder(int, CharSequence, PendingIntent)constructors with modernIcon.createWithResource()approachgetResources().getColor()withContextCompat.getColor()StatsActivity.java
getResources().getColor()withContextCompat.getColor()MainActivity.java
getResources().getColor()withContextCompat.getColor()Notes:
Addresses #159
What type of PR is this? (check all applicable)
Description
I did not fix EVERY deprecated API usage warning, so we may not want this PR to close 159 yet.
Related Issues
Were the changes tested?
have not been included