Start using new key for setting notifications dialog #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop-gap to ensure all new viewers of the notifications dialog are noted
nickoneill
approved these changes
Oct 25, 2025
Collaborator
|
What about this PR is a stop-gap and what's the long-term fix? |
Collaborator
Author
Stop-gap: start marking the dialog as seen with a new pref going forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop-gap to ensure all new viewers of the notifications dialog are noted
What type of PR is this? (check all applicable)
Description
Adds a new key for the notifications dialog setter, so that any new viewers of that dialog are noted. Due to a OneSignal configuration issue, users who viewed the dialog over a month ago will need to be re-shown the dialog. This is a stop-gap so we don't increase the number of users who must see the dialog a second time to get notifications
Related Issues