Added deep link support

[scottpeterson]

1. AndroidManifest.xml

Added a deep link intent filter to MainActivity to handle https://5calls.org/issue/{issueId} URLs:

• Added with android:autoVerify="true" for Android App Links
• Configured to handle HTTPS scheme, 5calls.org host, and /issue/ path prefix

2. MainActivity.java

Added deep link handling logic:

• New field: mPendingDeepLinkIssueId to store the issue ID from the deep link
• handleDeepLink(): Parses incoming intent URIs and extracts the issue ID from URLs like https://5calls.org/issue/1051
• onNewIntent(): Handles deep links when the app is already running (singleTop launch mode)
• handlePendingDeepLink(): Searches for the issue in the loaded issues list and either opens it or shows an error
• Modified onCreate() to call handleDeepLink() on initial launch
• Modified onIssuesReceived() callback to call handlePendingDeepLink() after issues are loaded

3. IssuesAdapter.java

• Added getAllIssues() getter method to allow MainActivity to search through all loaded issues

4. strings.xml

Added two new error messages:

• issue_not_found: "This issue isn't relevant anymore"
• issue_inactive: "This issue is no longer active"

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization

Description

Related Issues

• Related Issue #
• Closes Use deep links to let the user open 5calls.org pages in the Android app. #100

Were the changes tested?

• Yes, automated tests in please name test methods or files
• Yes, manually tested: using adb I sent intents to my device with known valid issueIds and known invalid issueIds and got the expected results.
• No, and this is why: please replace this line with details on why tests
  have not been included
• I need help with writing tests

[dektar]

I tried pulling this down onto my dev device and I tried to open https://5calls.org/issue/snap-contingency-funds-governors/, it did prompt me to open with Chrome or 5 Calls (yay!) but then just brought me to the main activity. I attached the debugger and it looks like the code is comparing the issue ID (something like 1051) to the part of the link after "issue/" (something like snap-contingency-funds-governors).

We should instead compare whatever is after https://5calls.org/ to Issue.permalink (see Issue.java), which will be something like /issue/snap-contingency-funds-governors/. This will not only make it possible to match normal nationwide issues, but also allow us to match issues with different paths like state sisues.

[scottpeterson]

I was wondering about the permalink. So we only care about matching the permalink portion of the deep link intent to existing issues? Or do we want to support potentially both the permalink slug AND the issueId?

[dektar]

I was wondering about the permalink. So we only care about matching the permalink portion of the deep link intent to existing issues? Or do we want to support potentially both the permalink slug AND the issueId?

Per Slack, just the permalink / slug, we won't link with issue id.

[scottpeterson]

@dektar switched to permalink handling..responded to your comments.

For invalid issues, it felt to me like the Snackbar was shown for a short time, but it's already LENGTH_LONG and I don't think we need it to be INDEFINITE nit for sure.

[dektar]

Overall comment:
When I tried going to an issue from a link it now goes to the IssueActivity and the correct page, but the contacts failed to load, so the IssueActivity contacts list said "no calls for this issue". Perhaps we have to wait for both the issues and contacts response to complete before forwarding to that activity?

One other nit below.

[scottpeterson]

Overall comment: When I tried going to an issue from a link it now goes to the IssueActivity and the correct page, but the contacts failed to load, so the IssueActivity contacts list said "no calls for this issue". Perhaps we have to wait for both the issues and contacts response to complete before forwarding to that activity?

One other nit below.

yep, we had to both wait for the contact response, but also the issue objects we fetch for deep linking bypass the recyclerview loading of the contacts field, so that had to be done manually.

Felt a bit hacky and my java ability is a bit out of date, so please take a look

[dektar]

Tiny nit before submit: please add spanish string in strings_es. I got this from Google Translate, which is probably OK to start with: "No se pudo encontrar esta llamada; puede que ya no sea relevante."

This will call Android CI to fail in general if we don't have string translations.

100% Optional: Add tests for the link extracting and matching logic. This codebase doesn't have good tests or test setup so it's OK if you don't do this.

Otherwise LGTM. I can add the Spanish string in a follow-up if you don't have time this weekend.

[dektar]

I can merge and we can fix the test in a follow-up, or you can fix now, LMK.

[dektar]

We should refactor this logic into a visible for testing, static method on main activity rather than mimicing logic here. otherwise changes in main activity won't cause this test to fail, and this test only will test itself!