Allow users to skip setting their location #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next: * Let users skip the location screen the first time they see it, or don't automatically show it after the tutorial, and * Show a prompt in MainActivity to set location if not yet set
And handling address error vs empty address when deep linking
Adds some TODOs
After returning from LocationActivity, IssueActivity refreshes the contacts list for the issue. Refactors out some common methods
Removes mentions of "zip" from LocationActivity and updates strings/layout a bit.
Until location is set, newletter signup is not shown (making an assumption that people aren't too invested yet)
Making it take up less space
scottpeterson
approved these changes
Nov 21, 2025
Larger clickable area, visually looks the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Users may now skip setting their location (LocationActivity) when coming directly from the tutorial. MainActivity shows a card prompting user to set their location in this case, but IssuesAdapter hides call counts. IssueActivity allows issues to be viewed and displays appropriate error message and a link to set location. IssueActivity listens to location changes so that it can refresh contacts dynamically after location is set.
Related Issues
Were the changes tested?
have not been included