Add space menu and window menu

[Huliiiiii]

Not implemented:

• j: Open jumplist picker
• ': Open last picker

---

• d: Open diagnostic picker
  VS Code doesn’t have a single-file diagnostic picker, so it currently behaves the same as D.

---

The window menu was copied directly from Silverquark’s fork.

[71]

Thank you! A couple minor comments.

[71]

nit: you can also keep this as an array to be more readable (also removing the opening [)

Suggested change

	],
	`.trim().split("\n"),

To remove the indentation, I would do .replaceAll(/^ {,18}/mg, "") or something like this to preserve the "internal" indentation.

[71]

Sorry if that wasn't clear, I meant writing the text multiline using a template literal

code: `
  if (...) {
    ...
  }`.replaceAll(/^ {,2}/mg, "")

This way it is a multiline string which is easy to read and edit in package.build.ts, and in the generated package.json it is an array of lines which is similarly easy to read (but less so than a multiline string).

[71]

Oh that's a neat idea!

[71]

No need to do it here, but perhaps we can check if the editor has horizontal / vertical splits already (maybe with vscode.window.tabGroups?), create them if needed (maybe vscode.window.showTextDocument() or using View: Split Editor), and then an empty file there? Also I'm not sure all of these steps are possible.

[71]

A few nits, but also the confusing indentation made us miss a problem: the window menu is defined within the space object, so we can't actually open it with w.

[71]

Sorry if that wasn't clear, I meant writing the text multiline using a template literal

code: `
  if (...) {
    ...
  }`.replaceAll(/^ {,2}/mg, "")

This way it is a multiline string which is easy to read and edit in package.build.ts, and in the generated package.json it is an array of lines which is similarly easy to read (but less so than a multiline string).

[Huliiiiii]

I don't understand why CI failed, but it should have followed the indentation correctly.
(The key "dance.menus" is indented with 4 spaces, and "space" is indented with 6 spaces.)

[71]

I don't understand why CI failed, but it should have followed the indentation correctly.

I think it wants the "following lines" to be indented wrt the property being defined. This fixed it for me:

diff --git a/extensions/helix/package.build.ts b/extensions/helix/package.build.ts
index 221ba72..d29a928 100644
--- a/extensions/helix/package.build.ts
+++ b/extensions/helix/package.build.ts
@@ -307,10 +307,10 @@ export const pkg = (modules: Builder.ParsedModule[]) => ({
                     'workbench.action.quickOpen',
                     quickOpenPrefix,
                   );`
-                  // The indentation of multi-line template strings
-                  .replaceAll("                  ", "")
-                  .replaceAll(/^ {,2}/mg, "")
-                  .split("\n")
+                    // The indentation of multi-line template strings
+                    .replaceAll("                  ", "")
+                    .replaceAll(/^ {,2}/mg, "")
+                    .split("\n")
                 ,
               },
             ],

As a small nit (since we need to change this code anyway), I think the following is a bit more readable:

diff --git a/extensions/helix/package.build.ts b/extensions/helix/package.build.ts
index 221ba72..7588f4a 100644
--- a/extensions/helix/package.build.ts
+++ b/extensions/helix/package.build.ts
@@ -307,10 +307,9 @@ export const pkg = (modules: Builder.ParsedModule[]) => ({
                     'workbench.action.quickOpen',
                     quickOpenPrefix,
                   );`
-                  // The indentation of multi-line template strings
-                  .replaceAll("                  ", "")
-                  .replaceAll(/^ {,2}/mg, "")
-                  .split("\n")
+                    // The indentation of multi-line template strings
+                    .replaceAll(" ".repeat(18), "")
+                    .split("\n")
                 ,
               },
             ],

There is another edge case with F: if the current file is in the workspace root directory, then asRelativePath() returns the input fsPath, i.e. an absolute path that VS Code does not provide autocompletion for. The following fixes it:

diff --git a/extensions/helix/package.build.ts b/extensions/helix/package.build.ts
index 221ba72..3f4ddfa 100644
--- a/extensions/helix/package.build.ts
+++ b/extensions/helix/package.build.ts
@@ -295,7 +295,7 @@ export const pkg = (modules: Builder.ParsedModule[]) => ({
                   const currentFileUri = editor.document.uri;
                   const currentDirectoryUri = vscode.Uri.joinPath(currentFileUri, '..');
                   const workspaceFolder = vscode.workspace.getWorkspaceFolder(currentFileUri);
-                  if (!workspaceFolder) {
+                  if (!workspaceFolder || currentDirectoryUri.fsPath === workspaceFolder.uri.fsPath) {
                     return await fallback();
                   }
                   const relativeDirectoryPath = vscode.workspace.asRelativePath(

[Huliiiiii]

Thanks for your suggestion, but I've found a better way to get the indentation.

[71]

Thank you!