Add lung4 scaffold with open fissures #287
Conversation
Fix common nodes on medial side
Ensure right lung has same numbers for nodes/elements if no left lung
Allow as low as 4 oblique elements in lung4 scaffold.
mlin865
left a comment
mlin865
left a comment
There was a problem hiding this comment.
Scaffold looks great and passed all tests. I've made couple of minor suggestions and also pending your fixes to the two issues discussed today:
- issues with edge related annotation groups when using refinement
- broken mesh when "lower lobe extension" = 0.0
Are you planning to add markers that are in older versions of lung to lung 4?
We're not fixing any marker points -- the apex location is a bit amorphous and everything else is tied down by the surfaces and edges already. |
|
I did add markers which are not used for fitting but in subsequence PCA steps. |
mlin865
left a comment
mlin865
left a comment
There was a problem hiding this comment.
All good and passed all tests. Just one typo to fix and good to go!
| tmp_line_ids.append(line.getIdentifier()) | ||
| face_line_ids.append(tmp_line_ids) | ||
| new_line_ids = set() | ||
| # if there is a single line between 2 faces can do less work later, but not if there are collpased faces |
|
@rchristie - Sorry i just noticed that the markers disappear when I am making the right lung only. Can you please resolve that issue? |
Put marker nodes in left/right lung groups too.
mlin865
left a comment
mlin865
left a comment
There was a problem hiding this comment.
Works fine now. Thanks for making the changes
2 participants
Built from ellipsoid octants, with 1 row of nodes on inner hilum common to all lobes on each lung.