Skip to content

Conversation

@armin-ilg
Copy link
Contributor

@armin-ilg armin-ilg commented Aug 14, 2024

BEGINRELEASENOTES

  • DDRec::VolSurface: Adding the capability to be only a segment of a cylinder <2π needed for ultra-light curved vertex concept.
    ENDRELEASENOTES

Hi everyone

I'm trying to make the ultra-light vertex detector concept working in full simulation, using k4geo from this PR. As a first step I added the functionality to VolCylinder to feature less than 2π circumference, changing the getLines function. Is there something else needed? Have in the past cylindrical sensitive surfaces actually been used in reconstruction?

Thank you,
Armin

Sensitive surfaces example:
Screenshot 2024-08-14 at 11 29 54

Co-authored-by: Andre Sailer <andre.philippe.sailer@cern.ch>
@andresailer andresailer marked this pull request as draft August 14, 2024 13:02
@andresailer
Copy link
Member

I converted this to a draft, until the whole chain is confirmed to be fully working.

@gaede
Copy link
Contributor

gaede commented Aug 20, 2024

Hi Armin,
I believe that adopting the getLines() as you have done should be all that is needed for Cylinders <2pi as the 'boundary' of the surface is handled by the volume. We use cylindrical surfaces for tracking in the ILD TPC, see e.g.:
https://github.com/iLCSoft/DDKalTest/blob/master/src/DDCylinderMeasLayer.cc
https://github.com/key4hep/k4geo/blob/main/detector/tracker/TPC10_geo.cpp
Cheers, Frank.

@github-actions
Copy link

Test Results

   18 files     18 suites   9h 35m 30s ⏱️
  372 tests   367 ✅ 0 💤 5 ❌
3 278 runs  3 273 ✅ 0 💤 5 ❌

For more details on these failures, see this check.

Results for commit 209cbe2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants