Skip to content

Conversation

@tmadlener
Copy link
Collaborator

BEGINRELEASENOTES

  • Add a cmake option (PODIO_ENABLE_SCHEMA_EVOLUTION_TESTS) to toggle the schema evolution tests that involve code generation as these more than double the time it takes to run cmake.

ENDRELEASENOTES

@tmadlener tmadlener force-pushed the toggle-schema-evol-tests branch from 1191b41 to 456f3ec Compare December 18, 2025 07:31
@jmcarcell
Copy link
Member

I'm not sure what I think about this. On one side, these tests are needed for PRs to be merged but no one will run them (but anyway in the end the ones submitting most of the PRs will be aware...). On the other hands it is a bit annoying to have to generate always all the models every time cmake runs. Alternative options would be not to have to generate the models every time cmake runs and generation being faster (?). Now there is the risk of forgetting to enable these tests in CI or locally. 🤷

@tmadlener
Copy link
Collaborator Author

The "problem" is that usual path for code generation is through the cmake macros and I would like these tests to go through the full machinery just to make sure that that in the end handles things properly. In principle all the generations are entirely independent so it could be quite trivially parallelized if cmake had an easy way to allow for that...

I think turning PODIO_USE_CLANG_FORMAT already makes code generation quite a bit faster, but I don't see an easy other way to speed it up further without heavily reworking things.

We could minimize the risk of forgetting to turn it on by setting this as ON by default, which would give "power users" a way to deliberately turning it off in case these tests are uninteresting or just hinder development for the moment. Additionally, if we add presets (#905), at least it would be a central switch to toggle for all CI and not one that has to be done in N places.

@jmcarcell
Copy link
Member

Yes, maybe ON by default is a better default.

@tmadlener tmadlener enabled auto-merge (squash) December 18, 2025 15:56
@tmadlener tmadlener merged commit 8aa5be0 into AIDASoft:master Dec 18, 2025
34 of 37 checks passed
@tmadlener tmadlener deleted the toggle-schema-evol-tests branch December 18, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants