Skip to content

Forward-declare PyObject not to have to include Python.h #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmcarcell wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Forward-declare PyObject not to have to include Python.h #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed5a55e
Forward-declare PyObject not to have to include Python.h
jmcarcell Dec 23, 2025
fc9ccf0
Remove unnecessary target_include_directories for python
jmcarcell Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions include/podio/detail/Pythonizations.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@
#define PODIO_DETAIL_PYTHONIZATIONS_H

#define PY_SSIZE_T_CLEAN
#include <Python.h>
#include <string>

typedef struct _object PyObject;

namespace podio::detail::pythonizations {

// Callback function for the subscript pythonization
Expand All @@ -16,4 +17,4 @@ void pythonize_subscript(PyObject* klass, const std::string& name);

} // namespace podio::detail::pythonizations

#endif // PODIO_DETAIL_PYTHONIZATIONS_H
#endif // PODIO_DETAIL_PYTHONIZATIONS_H
3 changes: 0 additions & 3 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ FUNCTION(PODIO_ADD_LIB_AND_DICT libname headers sources selection )
$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include>
$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
)
target_include_directories(${libname} SYSTEM PUBLIC
${Python3_INCLUDE_DIRS}
)

# dictionary
set(dictname ${libname}Dict)
Expand Down
4 changes: 3 additions & 1 deletion src/Pythonizations.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
#include <cstring>
#include <stdexcept>

#include <Python.h>

namespace podio::detail::pythonizations {

// Callback function for the subscript pythonization
Expand Down Expand Up @@ -52,4 +54,4 @@ void pythonize_subscript(PyObject* klass, const std::string& name) {
Py_DECREF(method);
}

} // namespace podio::detail::pythonizations
} // namespace podio::detail::pythonizations