Sd 552 test the new architecture detached #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
githinho
reviewed
Feb 28, 2022
Comment on lines
64
to
66
| address fetchedIssuer = _safe_issuer_fetch(params.asset); | ||
| address issuerProcessed = fetchedIssuer != address(0) ? fetchedIssuer : params.issuer; | ||
| require(issuerProcessed != address(0), "CfManagerSoftcapVesting: Invalid issuer."); |
Contributor
There was a problem hiding this comment.
This could potentially cause problems because the user can define issuer in params but another issuer is set in the constructor. Maybe add require to this logic.
Comment on lines
68
to
74
| uint256 fetchedPricePrecision = _safe_price_precision_fetch(params.asset); | ||
| uint256 pricePrecisionProcessed = fetchedPricePrecision > 0 ? fetchedPricePrecision : params.tokenPricePrecision; | ||
| require(pricePrecisionProcessed > 0, "CfManagerSoftcapVesting: Invalid price precision."); | ||
|
|
||
| address paymentMethodProcessed = params.paymentMethod == address(0) ? | ||
| IIssuerCommon(issuerProcessed).commonState().stablecoin : | ||
| params.paymentMethod; |
Contributor
There was a problem hiding this comment.
This is the same as above. Not sure what we get by restricting the payment method to issuer stablecoin
* decouple campaign price from asset state removed the tokenPricePrecision property from assets use priceDecimals rather than price precision (use 4, not 10**4) provide priceDecimals as a parameter while creating campaign provide priceDecimals as a parameter while updateing price on ApxRegistry (important for liquidations) track priceDecimals when storing the highestSellPrice on asset state (important for liquidations) make all the _token_value() methods look the same (operations ordering) fix tests add priceDecimalsPrecision to the campaign common state fix deployer service scripts to take into account new priceDecimals parameter when creating campaigns * PR fixes * PR fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.