-
-
Notifications
You must be signed in to change notification settings - Fork 18
[Feature, Improvement]: Disable converging, prevent IllegalArgumentException #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DerToaster98
commented
Nov 24, 2024
- Converging automatically toggles off, if the range is less than 0. We tried setting it to 0 with the old version and it still tried to converge. Specifying a long list of blocks that are "transparent" is not really a option if you dont want converging
- Our console used to get spammed with "X is not finite" exceptions. Clamped the vectors now so it does not run into that try block as printing out all those exceptions slows the server down.
|
Need to do some more testing, looks like i broke directors with the clamping |
(cherry picked from commit acce226)
Every time changes are attempted it breaks things, I am hesitant to accept changes here. |
For your information, that has been fixed in the following commit. That patch is live on TTE since 3 weeks ago and has seen a lot of combat since then. Works just fine. |
|
If you are intersted, the part that broke it is explained in the commit "correct mathhelper". Basically Double.MIN_VALUE is not what one expects at first glance, instead it is the lowest positvice double value to match IEEE754 format. What the function does overall is limiting the value between the min and max limits, which prevents the "not finite" exception from occuring |