Skip to content

Conversation

@DerToaster98
Copy link
Contributor

  • Converging automatically toggles off, if the range is less than 0. We tried setting it to 0 with the old version and it still tried to converge. Specifying a long list of blocks that are "transparent" is not really a option if you dont want converging
  • Our console used to get spammed with "X is not finite" exceptions. Clamped the vectors now so it does not run into that try block as printing out all those exceptions slows the server down.

@DerToaster98 DerToaster98 marked this pull request as draft November 24, 2024 17:45
@DerToaster98
Copy link
Contributor Author

Need to do some more testing, looks like i broke directors with the clamping

(cherry picked from commit acce226)
@DerToaster98 DerToaster98 marked this pull request as ready for review November 24, 2024 18:10
@TylerS1066
Copy link
Collaborator

Need to do some more testing, looks like i broke directors with the clamping

Every time changes are attempted it breaks things, I am hesitant to accept changes here.

@DerToaster98
Copy link
Contributor Author

Need to do some more testing, looks like i broke directors with the clamping

Every time changes are attempted it breaks things, I am hesitant to accept changes here.

For your information, that has been fixed in the following commit. That patch is live on TTE since 3 weeks ago and has seen a lot of combat since then. Works just fine.

@DerToaster98
Copy link
Contributor Author

If you are intersted, the part that broke it is explained in the commit "correct mathhelper". Basically Double.MIN_VALUE is not what one expects at first glance, instead it is the lowest positvice double value to match IEEE754 format.

What the function does overall is limiting the value between the min and max limits, which prevents the "not finite" exception from occuring

@TylerS1066 TylerS1066 merged commit 24e32d7 into APDevTeam:main Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants