Skip to content
This repository was archived by the owner on Jul 7, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -106,16 +106,13 @@ class LetterCommandService(
receiverId = DomainId(command.userId),
letterId = DomainId(command.letterId),
)

val independentLetter =
IndependentLetter.create(
sender =
SenderInfo(
senderId = sendLetter.senderId,
senderName =
sendLetter.senderName
?: sendLetter.senderId
?.let { userManagementPort.getUserNotNull(it).username }
.orEmpty(),
senderName = sendLetter.senderName ?: ANONYMOUS_SENDER_NAME,
),
receiver =
ReceiverInfo(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import com.asap.application.letter.port.out.IndependentLetterManagementPort
import com.asap.application.letter.port.out.SendLetterManagementPort
import com.asap.application.letter.port.out.SpaceLetterManagementPort
import com.asap.application.space.port.out.SpaceManagementPort
import com.asap.application.user.port.out.UserManagementPort
import com.asap.common.page.PageRequest
import com.asap.common.page.Sort
import com.asap.domain.common.DomainId
Expand All @@ -16,7 +15,6 @@ import org.springframework.transaction.annotation.Transactional
@Transactional(readOnly = true)
class LetterQueryService(
private val sendLetterManagementPort: SendLetterManagementPort,
private val userManagementPort: UserManagementPort,
private val independentLetterManagementPort: IndependentLetterManagementPort,
private val spaceLetterManagementPort: SpaceLetterManagementPort,
private val spaceManagementPort: SpaceManagementPort,
Expand All @@ -32,9 +30,8 @@ class LetterQueryService(
receiverId = DomainId(query.userId),
letterId = DomainId(query.letterId),
).also {
val sender = it.senderId?.let { userManagementPort.getUserNotNull(it) }
return GetVerifiedLetterUsecase.Response(
senderName = sender?.username,
senderName = it.senderName,
content = it.content.content,
sendDate = it.createdDate,
templateType = it.content.templateType,
Expand Down Expand Up @@ -76,7 +73,7 @@ class LetterQueryService(
independentLetterManagementPort.getNearbyLetter(DomainId(query.userId), DomainId(query.letterId))
return GetIndependentLettersUsecase.Response.One(
senderName = letter.sender.senderName,
letterCount = letterCount.toLong(),
letterCount = letterCount,
content = letter.content.content,
sendDate = letter.receiveDate,
images = letter.content.images,
Expand Down
Loading