Space - Lee #35
Open
Space - Lee #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
March 30, 2020 11:31
…h depending on whether the string length is odd or even, passes all tests
…re different', see comments
… of specific letters are different
…er are different, but the string lengths are the same', 2 failures in other tests
…es, passes all tests!
CheezItMan
reviewed
Apr 2, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Good work, you hit most of all the learning goals here. Well done.
Take a look at my comments and let me know if you have any questions.
| @@ -1,3 +1,17 @@ | |||
| def intersection(list1, list2) | |||
lib/palindrome_permutation.rb
Outdated
Comment on lines
10
to
14
| if string.length.even? # the palindrome should have two of each letter | ||
| return lookup_hash.length == string.length / 2 | ||
| elsif string.length.odd? # the palindrome should have only one odd letter out | ||
| return lookup_hash.length == (string.length / 2) + 1 | ||
| end |
There was a problem hiding this comment.
I don't think this would work if a letter appears more than 2 times. Consider oooo, it's a palindrome, if a weird one.
| @@ -1,4 +1,28 @@ | |||
|
|
|||
| def permutations?(string1, string2) | |||
There was a problem hiding this comment.
👍 I think this could be simplified a bit, but otherwise well done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.