summit: Add build / builder sizing logic to build queue #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarkah
force-pushed
the
task/build-size-config
branch
from
332599c to
5737247
Compare
tarkah
force-pushed
the
task/build-size-config
branch
from
5737247 to
021cf5f
Compare
Most of this commit revolves around removing the shared `service::Config` as each service should have its own config so we can easily extend them & not deal w/ unrepresentable states. The rest revolves around being able to associate a `size` to both builders & tasks (recipe names) so that we can intelligently queue up builds on the correct sized builder.
tarkah
force-pushed
the
task/build-size-config
branch
from
021cf5f to
5e7860a
Compare
ermo
approved these changes
Jan 5, 2026
Member
ermo
left a comment
ermo
left a comment
There was a problem hiding this comment.
This has been in testing for three weeks now with the DoS fix in place, and is now behaving as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this commit revolves around removing the
shared
service::Configas each service shouldhave its own config so we can easily extend them
& not deal w/ unrepresentable states.
The rest revolves around being able to associate
a
sizeto both builders & tasks (recipe names)so that we can intelligently queue up builds on the correct sized builder.
SIGHUP support was also added to
summitwhich allowsreloading the config at runtime so
build_sizescan be updatedw/out having to restart summit.