Features/async trainer #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allenanie
force-pushed
the
features/async_trainer
branch
from
ee49d2c to
c103b17
Compare
allenanie
force-pushed
the
experimental
branch
from
ef542aa to
c0a0282
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new Controller, AsyncTrainer, and AsyncPrioritySearch classes.
This implements a fully async version of PrioritySearch, which previously uses batching, so it can address the issue of PrioritySearch being blocked by some time-consuming runs in a batch. The periodic testing is also now non-blocking, so long as the num_threads is large enough.
The implementation is fully compatible with Trainer api. It provides an additional async_train coroutine for future fully async usages.
Preliminary tests on convex optimization worked out and showed improving performance.