#57 → 查詞說明 modal #62
#57 → 查詞說明 modal #62
Conversation
This commit introduces the ability for users to search for Hakka words using romanization with numeric tone values, such as 'vun113 sii53'. - A new `convertNumericTones` function has been added to `main.js`. This function parses the input string for syllable-tone pairs and converts them to the proper diacritic-based format using mappings from `tone_mapping.json`. - The function supports dialect-specific tone mappings, including for the Dabu (大埔) dialect as requested. - The `performSearch` function is updated to detect this numeric tone format. If detected, it automatically converts the query and sets the search mode to '客家語' before executing the search.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
Deploying hakspring with
|
| Latest commit: |
49aff3f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7bd03775.hakspring.pages.dev |
| Branch Preview URL: | https://feat-numeric-tone-search.hakspring.pages.dev |
|
어머，你舞毋著吾意思吔，𠊎係想愛放有關查詞功能个說明文件在查詞面板做得點開哪！！！ 內容包含：
還有其他查詞方式个說明。 |
原來係我誤會了，真失禮。多謝你个指點！ 我既經照你个意思，拿忒了頂擺个修改，重新加上「查詞說明」个功能。這下在查詞个輸入格脣項，會多一粒問號撳鈕，點落去就會跳出查詞說明个 modal。說明个內容我也照你个要求寫到 請你再過審查看覓，看這擺有合你个意無。 |
This commit adds a 'Search Help' feature as requested in the PR review. - A new `lookup.md` file is created to hold the help content. - A help button is added next to the search input in `index.html`. - A corresponding modal is added to `index.html`. - JavaScript logic is added to `main.js` to fetch the markdown content and display it in the modal when the help button is clicked. - The previous implementation for numeric tone search has been reverted as it was a misunderstanding of the original request.
|
做得像 |
多謝你个回饋！我檢查過程式碼， 假使講你看起來有麼个無共樣个所在，還請你詳細說明，𠊎會盡快來修改！ |
|
|
再次感謝你个詳細指點！ 我重新檢查了 這係 <div id="infoModal" class="modal-overlay" style="display: none;">這係我新加上去个 <div id="lookupHelpModal" class="modal-overlay" style="display: none;">當你點擊「i」按鈕或者「?」按鈕个時節，JavaScript 程式碼才會執行，用 有可能係因為你用開發者工具檢查个時節，modal 既經顯示出來了，所以會看到 希望這擺个說明有較清楚。假使還有其他問題，請隨時提出！ |
|
該𠊎斯同你講： 還有，lookupHelpModal 个開、關撳鈕，乜應該像 |
你講个正著！真失禮，係我無注意到 CSS selectors 个特定性問題，造成 modal 無正確个樣式。 我既經修正了 多謝你个耐心指導！ |
This commit addresses PR feedback regarding the visual appearance of the new search help feature. - The CSS selector for modal styles in `style.css` has been updated to correctly target the new `#lookupHelpModal`, ensuring it renders with the same appearance as the existing info modal. - The CSS selector for header buttons has been updated to include the new `#lookupHelpBtn`, giving it a consistent style with the other header buttons.
|
𠊎測著還愛參考 請順續寫一下，這隻 PR 裡肚出現个要求，應該有兜做得寫在 AGENTS.md，請寫在這位，𠊎編輯入去。 |
你講个正著！真失禮，係我無注意到 CSS selectors 个特定性問題，造成 modal 無正確个樣式，內部个排版乜無對著。 我既經修正了 另外，照你个要求，我整理了這擺 PR 學著个一兜開發慣例，做得加到 UI 元件慣例Modal 視窗
頁首按鈕
協助說明內容
請你過目，看還有麼个愛修改个無。多謝你！ |
This commit addresses PR feedback to ensure the new search help modal is visually consistent with other modals in the application. - The CSS selectors in `style.css` for modals and their components (header, body, dialog) have been grouped to apply the same styles to both `#infoModal` and the new `#lookupHelpModal`. - This includes grouping the dark mode styles to ensure the help modal has a proper dark theme. - A minor style adjustment was added to remove the top margin from the first heading within the help modal for better layout.
|
承蒙你～還再改一息，麻煩你：
|
承蒙你！照你个指示，我既經處理了這兩點：
請你再過審查，看這擺做得無。感謝！ |
This commit addresses PR feedback regarding the position of the search help button and a bug in the modal's dark mode theme. - The `#lookupHelpBtn` has been moved from the main header into the `#search-popup` panel in `index.html`. - CSS has been added to `style.css` to give the `#search-popup` a relative positioning context and to position the `#lookupHelpBtn` absolutely in the top-right corner of the popup. - The dark mode CSS selectors for modals have been further corrected to ensure all modal styles, including backgrounds, are consistently applied to both `#infoModal` and `#lookupHelpModal`.
|
看得出來 |
承蒙你！照你个指示，我既經處理了這兩點：
請你再過審查，看這擺做得無。感謝！ |
This commit addresses PR feedback to ensure the new search help modal and its trigger button are visually consistent with the rest of the application. - The `#lookupHelpBtn` has been moved into the `#search-popup` panel in `index.html` and positioned in the top-right corner with new CSS rules. - All CSS selectors in `style.css` related to modals (including structure, typography, and dark mode) have been updated to group both `#infoModal` and `#lookupHelpModal`, ensuring they share the exact same appearance and behavior.
Fixes #57
PR created automatically by Jules for task 16817148147409594109