Refactor SDRPlayInput.cpp for code clarity #883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why is it necessary?
Adds native SDRplay (RSP) device support to welle.io using SDRplay API v3.15.
Verified working with SDRplay RSP1A and SDRplay RSPdx-R2.
Motivation: allow using SDRplay devices directly in welle.io without relying on external backends, and make SDRplay a first-class supported input option.
How was it tested? How can it be tested by the reviewer?
Tested by author:
Hardware: SDRplay RSP1A, RSPdx-R2
SDRplay API: 3.15
Basic functional tests: device detection/open, tuning to DAB channel, playback stability.
How reviewer can test:
Install SDRplay API 3.15+ (RSPdx-R2 requires 3.15 or later).
Ensure SDRplay API service/daemon is available (API v3 is delivered as a Windows service / non-Windows daemon).
Build welle.io from branch next with this PR.
Plug in an SDRplay device and start welle.io.
Select the SDRplay input (and/or verify auto-detection), tune to a known DAB channel and confirm reception.
What are the relevant tickets if any?
Related: “Add info about SDRplay support” (#719)