Improve compatibility with custom modded milk for cheese making #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/com/github/alexthe666/rats/data/tags/RatsItemTags.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, a user asked if it was possible to make cheese from our mod's custom milk Item or Fluid, so we wanted to PR to this mod instead of hardcoding compatibility into our mod, so that it's also compatible with any other mod that might add custom milk.
This very small PR adds the
forge:milktag toRatsItemTagsand uses it instead of just checking if the item is the vanilla minecraft milk, and also uses the already existingisMilkfunction in some places where it was previously only checked against forge's milk fluid.