[PWGHF] Address clang-tidy issues in LcToPKPi-related files #14358
+89
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
O2 linter results: ❌ 0 errors, |
github-actions
bot
changed the title
vkucera
reviewed
Dec 30, 2025
| /// \param isMc boolean flag whether MC or data is processed | ||
| template <int ReconstructionType> | ||
| void reserveTables(size_t candidatesSize, bool isMc) | ||
| void reserveTables(int64_t candidatesSize, bool isMc) |
Collaborator
There was a problem hiding this comment.
Why is this needed? Doesn't the reserve method take an unsigned type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang-tidy issues present in workflows related to$\Lambda^+_c\rightarrow pK\pi^+$ reconstruction are fixed.
I am not 100% sure that some of the narrowing conversion issues are addressed in proper places (e.g. change of the Configurable
double->floatwhen it is consumed by function withfloatparameter; or issues withint8_tvalues), therefore an attentive look and feedback is appreciated.