-
Notifications
You must be signed in to change notification settings - Fork 162
feat: Add macOS support with platform-specific implementations #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Launches diskutil process to perform the actual partition changes.
Apply tabs (display size 8) and comments styling. Also refactor darwin/block_device.c map_partition_to_disk with a cleaner implementation.
Simplify and cleanup the Makefile a bit. Good reference on dependency files generation: https://make.mad-scientist.net/papers/advanced-auto-dependency-generation/
Mixing feature macros when linking could be an issue. If we want to keep _XOPEN_SOURCE=600 we should update the Makefile with rules per target.
Rework the compilation to build the correct objects for each target.
|
Hi @lkraider, I'm so sorry, but I don't have large blocks of time to review large pull requests like this one. I don't want to diminish your work; it's my life that's too busy. Can you break your pull request into small ones so I can review them in short opportunities that I have? Thank you for the effort you've put into this pull request. |
|
Hi, no problem, I understand. The functionality code is mostly in the This patch contains a restructuring for the purpose of multi-platform support, but doesn't change the current supported platform functionality. I could try and create a PR with only the darwin function and minimal existing code restructuring. |
|
I don't have an overall understanding of your pull request, so I'm unable to advise you on how to break it. I recommend breaking into as many pull requests as possible, so reviews are not daunting. Please don't issue all pull requests simultaneously, since things should get clearer as we review the pull requests. I appreciate your willingness to work this out. I hope this grows into a rewarding collaboration for both of us. |
|
Moving to #246 |
This PR introduces a comprehensive refactoring for multi-platform support, with code for native macOS partitioning support, while maintaining full Linux compatibility. The changes include:
Key Changes
Platform specific code tree:
Platform independent code tree:
Implementation Notes
parted)Testing
Limitations