Skip to content

Conversation

@ewassef
Copy link
Contributor

@ewassef ewassef commented May 14, 2025

This pull request enhances the init.sh script with improved Docker permissions handling, better OS and architecture detection, and streamlined release asset downloading. It also removes unused or outdated code for clarity and maintainability.

Docker permissions and OS-specific setup:

  • Enhanced Docker permissions handling for Linux and macOS, including checks for Docker group membership, Docker CLI installation, and Docker Desktop status. Added support for OS detection and error handling for unsupported systems.

OS and architecture detection:

  • Added logic to detect the operating system and architecture (linux, darwin, x64, arm64) and dynamically set the appropriate release asset name.

Release asset downloading:

  • Simplified release asset downloading by removing the need for a GitHub token and using the browser_download_url field instead of asset ID. Improved error messaging for missing assets.

Path management:

  • Restored logic to update the user's PATH with the binary directory if not already present, ensuring the CLI is accessible after installation.

Code cleanup:

  • Removed outdated or commented-out code, such as unused sudo gpasswd commands and redundant token-based asset download logic, for improved readability and maintainability.

@ewassef ewassef requested a review from chaosmonkey May 14, 2025 23:50
@ewassef ewassef added the patch release Indicates that the patch number of the SemVer should be changed. ie 1.0.x label May 14, 2025
ewassef and others added 6 commits May 14, 2025 21:47
@ewassef ewassef temporarily deployed to github-pages May 24, 2025 01:16 — with GitHub Pages Inactive
@ewassef ewassef temporarily deployed to github-pages May 24, 2025 01:26 — with GitHub Pages Inactive
@ewassef ewassef temporarily deployed to github-pages May 24, 2025 01:35 — with GitHub Pages Inactive
@ewassef ewassef temporarily deployed to github-pages May 24, 2025 01:42 — with GitHub Pages Inactive
Signed-off-by: Eddie <eddie@wassef.com>
@ewassef ewassef temporarily deployed to github-pages May 25, 2025 18:40 — with GitHub Pages Inactive
@ewassef ewassef merged commit f1391e8 into main May 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch release Indicates that the patch number of the SemVer should be changed. ie 1.0.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants