Skip to content

Conversation

@oczoske
Copy link
Collaborator

@oczoske oczoske commented Dec 29, 2025

SkycalcTERCurve gains a prettier __str__ and can be updated on the fly with, e.g.,

metis['skycalc_atmosphere'].update(pwv=20, airmass=3)

(the name of the branch is somewhat misleading as there is only a small change to AtmoLibraryTERCurve)

@oczoske oczoske self-assigned this Dec 29, 2025
@oczoske oczoske added enhancement PR adding or improving a feature (use "Feature" type for issues (requests), not this label) effects Related to a ScopeSim effect labels Dec 29, 2025
@oczoske oczoske moved this to 👀 Awaiting Review in ScopeSim-development Dec 29, 2025
@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

❌ Patch coverage is 67.44186% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.87%. Comparing base (158b4d2) to head (c161011).

Files with missing lines Patch % Lines
scopesim/effects/ter_curves.py 53.57% 13 Missing ⚠️
scopesim/source/source_fields.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
- Coverage   74.94%   74.87%   -0.07%     
==========================================
  Files          69       69              
  Lines        8843     8863      +20     
==========================================
+ Hits         6627     6636       +9     
- Misses       2216     2227      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing jumped out at me as potentially problematic, so I assume it's good. Does have tests after all. "prevent[ion of] mental anguish" is always welcome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effects Related to a ScopeSim effect enhancement PR adding or improving a feature (use "Feature" type for issues (requests), not this label)

Projects

Status: 👀 Awaiting Review

Development

Successfully merging this pull request may close these issues.

SkycalcTERCurve does not offer a possibility to change parameters programmatically

3 participants