Skip to content

Fixed issue #42 where setting SetOptOut before Start causes exception to be th… #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JimiC wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed issue #42 where setting SetOptOut before Start causes exception to be th… #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Source/CSharpAnalytics/AutoMeasurement/BaseAutoMeasurement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,16 @@ public async void Start(MeasurementConfiguration configuration, string launchKin
sessionManager = new SessionManager(sessionState, configuration.SampleRate);
await StartRequesterAsync();

if (delayedOptOut != null) SetOptOut(delayedOptOut.Value);
// Preserve 'delayedOptOut' value to use in condition checking
var hasDelayedOptOut = delayedOptOut;
if (hasDelayedOptOut.HasValue) SetOptOut(delayedOptOut.GetValueOrDefault());

Client.Configure(configuration, sessionManager, GetEnvironment(), Add);

// Sometimes apps crash so preserve at least session number and visitor id on launch
await Save(sessionManager.GetState(), SessionStorageName);
// Avoid re-saving if a delayed optout was set (save already occurred in 'SetOptOut')
if (!hasDelayedOptOut.HasValue)
await Save(sessionManager.GetState(), SessionStorageName);

HookEvents();
}
Expand Down