Skip to content

Sync: Fix renderer crash when network disconnects after upload #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gavande1 wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Sync: Fix renderer crash when network disconnects after upload #2334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions src/hooks/sync-sites/use-sync-push.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,12 +142,31 @@ export function useSyncPush( {
return;
}

const response = await client.req.get< ImportResponse >(
`/sites/${ remoteSiteId }/studio-app/sync/import`,
{
apiNamespace: 'wpcom/v2',
let response: ImportResponse;
try {
response = await client.req.get< ImportResponse >(
`/sites/${ remoteSiteId }/studio-app/sync/import`,
{
apiNamespace: 'wpcom/v2',
}
);
} catch ( error ) {
// Network errors (e.g., offline) should be handled gracefully
// The error will be handled when the user comes back online
console.error( 'Failed to get push progress:', error );

// Skip Sentry reporting for expected network errors (crossDomain errors)
if (
error instanceof Error &&
'crossDomain' in error &&
( error as Error & { crossDomain?: boolean } ).crossDomain
) {
return;
}
);

Sentry.captureException( error );
return;
}

let status: PushStateProgressInfo = pushStatesProgressInfo.creatingRemoteBackup;
if ( response.success && response.status === 'finished' ) {
Expand Down
Loading