This repository was archived by the owner on Oct 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Simdem v2 Merge #110
Open
lastcoolnameleft
wants to merge
185
commits into
main
Choose a base branch
from
simdem2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Simdem v2 Merge #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed typo in nosetests command
Added __init__.py so tests can be run
the learn more url as changed, this fix the 404 error
[readme] update `learn more` link
Fixing link to blog post.
By using `os.path.dirname(__file__)` you can run the test from any directory/cwd and it will find the right path to the sample module. Without it you might accidentally import it from the wrong directory (i.e. if you have a development version of your project checked out, but you also have one installed in the system path, you may think that your tests pass when in fact they were testing the system installation rather than the development version).
tests: use __file__ to determine library path
add a Python gitignore
If it's intended to use semantic versioning then it's doesn't make sense to start from a bug fix release.
Change initial version to be 0.1.0
I had problems transissioning form python 2 to 3 due to imports failing when running tests. This shows (what i hope) is the correct way of dealing with imports.
Lets allow the helpers to be helpfull
…(it is required on install)
need to include the LICENSE file, otherwise pypi installs are broken …
Signed-off-by: Tommy Falgout <tommy@lastcoolnameleft.com>
Signed-off-by: Tommy Falgout <tommy@lastcoolnameleft.com>
Contributor
Author
|
@rgardler Last chance to declare something before I merge! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.