-
Notifications
You must be signed in to change notification settings - Fork 15
Report Data Visualization #1439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
…Team/celts into visualizeReportData
…nd unnecessary lines cleared up
…twareDevTeam/celts into visualizeReportData
…twareDevTeam/celts into visualizeReportData
…Team/celts into visualizeReportData
…SoftwareDevTeam/celts into bonnerCheckmarkProfile orked on the username and other rawclasslevel possibility
…twareDevTeam/celts into visualizeReportData
bakobagassas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks so cool! I loved the improvement.
I think it would be even better to have the chart as pdf rather than png
bakobagassas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we can see the bar char option as well as the line chart option but we are not able to change it, same for the engagement per term hover. I think it would be better to have it in a document where we can visualize both charts. Or perhaps making it in a way that when we download the bar chart, it only says Bar chart in the downloaded version and not bar chart AND line chart.
bakobagassas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also the bar chat is a little bit confusing. It is unclear what the dependent variable is on the y-axis. Furthermore, I think it is confusing how the line graph seems to be about the number of engagements and the bar graph seems to be about the completed summer experience. We should either keep it constant by having a line graph for both engagement and summer experience OR having a bar graph and a line graph for either engagement or summer experience.

|
…Team/celts into visualizeReportData I have changed so that the buttons do not get downloaded in the pictures, a new data visualization and renaming and adding x and y labels.
bakobagassas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The graph purpose has been standardized, that's nice! I think now we should not have "summer complete" and "summer incomplete" anymore on the bar graph since the graph is not dealing with summer completion anymore. Furthermore, I think the color of the bar graph should hence be something like green since we are only talking about engagement and not completion anymore. 
bakobagassas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now!


CCE Minor Data Visualization
Fixes #
Changes
Testing
Set up
Checkout the branch
git checkout visualizeReportDataPull the code when you are in the branch
git pullIn app>logic>minor.py in the getMinorProgress() function, add the follow code lines after line 118 (be mindful of indentations):
for a in range (0, len(engagedStudentsList)-1, 2):
engagedStudentsList[a]['hasSummer'] = "Completed"
Reset the database
database/reset_database.sh testRun the test suite to make sure all the tests are working
tests/run_tests.shRun the application
flask runView Chart and Download it.