Skip to content

Conversation

@bakobagassas
Copy link
Contributor

Issue Description

We reworked the event List tabs, removed some tabs, added some and set some conditions.

Fixes #1570

Changes

'Other Events' was removed.
'Student-Led Services' was renamed to 'Volunteer Opportunities', and only shows events with the isService flag set to true.
We added a Labor tab, only visible to CELTS labor students, with the events that are marked Labor Only
The Training and Education and Engagement tabs now exclude events that are marked Labor Only

Testing

before
image

after
image

  • On the CELTS app menu, click on events list
  • You should see a page with several tabs, including the ones we added/modified "Celts Labor" and "Volunteer Opportunities" as well as their content

@ojmakinde ojmakinde changed the title Celts labor Changed Event List Groupings Sep 12, 2025
@bakobagassas bakobagassas self-assigned this Nov 5, 2025
@bakobagassas bakobagassas requested a review from Kafui123 November 5, 2025 21:57
@JohnCox2211 JohnCox2211 requested review from JohnCox2211 and removed request for Kafui123 November 5, 2025 22:08
@JohnCox2211
Copy link
Contributor

JohnCox2211 commented Nov 5, 2025

I need some elaboration on a couple of things:

  • Is the Labor Only tab supposed to only be visible by labor students, or do you mean that it should be viewed by them and staff? As of now, labor students and staff both see it.

  • What makes an event a Labor-Only event? I created a CELTS-Sponsored Event as an Education and Engagement event, and it was sorted into the Education and Engagement tab as well as the Labor Only tab. Are CELTS-sponsored events Labor-Only events?

@bakobagassas
Copy link
Contributor Author

I need some elaboration on a couple of things:

  • Is the Labor Only tab supposed to only be visible by labor students, or do you mean that it should be viewed by them and staff? As of now, labor students and staff both see it.
  • What makes an event a Labor-Only event? I created a CELTS-Sponsored Event as an Education and Engagement event, and it was sorted into the Education and Engagement tab as well as the Labor Only tab. Are CELTS-sponsored events Labor-Only events?
  • For your first point, both labor and staff should see the labor events
  • I will check the second point and get back to you

@JohnCox2211
Copy link
Contributor

When trying to look at the Events List with your most recent code, I get the following error:

image

There seems to be something wrong with the modification to your query.

Copy link
Contributor

@JohnCox2211 JohnCox2211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refer to previous comments

BrianRamsay
BrianRamsay previously approved these changes Dec 17, 2025
Copy link
Contributor

@BrianRamsay BrianRamsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

@github-actions
Copy link

View Code Coverage

@BrianRamsay BrianRamsay merged commit d44a340 into development Dec 17, 2025
4 checks passed
@BrianRamsay BrianRamsay deleted the Celts-Labor branch December 17, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rework Event List tabs

8 participants