Skip to content

Conversation

@Meatchema
Copy link
Contributor

@Meatchema Meatchema commented Nov 13, 2025

Issue Link

#505

Summary

This Merge Request introduces student approval functionality for adjusted and modified Labor Status Forms. At this stage, student approval has been fully implemented for adjustment forms. In this workflow, both the student and the supervisor must approve the application before any changes are applied to the Labor Status Form.

Support for modified forms is not yet included in this MR. A “modified” form is generated when a supervisor updates a Labor Status Form after the student has already approved but before the supervisor has approved - i.e., while the form is still in a pending state. Student approval for the modification process will be added in a future MR.

Key Changes

  • Added a Alter Tablet that allows us to search the database for !!! in Prod Database
  • Added Form Link to the 10th Form template
  • Added a pre-student approval adjustment counter and elif statement in allpendingform.py
  • Creation of New Value, Old Value, and Approve Link Variable
  • Changes Status in AlterLSF from “pending” to “Pre-Student’
  • Creation of lsfID within adjustedForm-used to directly link adjusted form and laborstatus form to get old and new values to present to users
  • Within studentEmailConfirmation.html we created a condition that will tell the student their old vs new changes in the actual Labor status form.
  • Added new weekly hours variable to studentHistoryModal.htm so that students can see their Old vs New Changes written out in their modal.

Testing Instructions / Screenshots

Checkout Branch: 505-student-approval-for-modified-and-adjusted-forms

General setup for the config in your IDE:
Go to the secret config (Go to the secret_config.yaml file underneath config.) and paste the statement below the financial aid email as follows (don't forget to set your password and your email in the code below):
ALWAYS_SEND_MAIL: True
MAIL_SERVER: "smtp.gmail.com" #use smtp.gmail.com for gmail or smtp.office365.com for Berea
MAIL_PORT: 465 #: use port 465 for Gmail, use 587 for Berea
MAIL_USERNAME: 'put your personal email here ' #the email of the sender
MAIL_PASSWORD: 'Put the password that you have generated in here' #Add the password of the sender
For the password above, go to your Gmail and turn on your 2-step verification, followed by setting an app passowrd, you will put that password in the statement above
MAIL_USE_TLS: False # False for gmail, True for berea
MAIL_USE_SSL: True # True for gmail, False for berea
MAIL_DEFAULT_SENDER: 'put your personal email here @'
MAIL_OVERRIDE_ALL: 'put your personal email here @gmail.com'
REPLY_TO_ADDRESS: "laborstatusform-aaaaazdxy4j2lsinl67ikumy4y@studentprogrammers.slack.com"
note: Edit the config where MAIL_SERVER, MAIL_PORT, MAIL_USE_TLS, MAIL_USE_SSL is using the gmail version
For the MAIL_USERNAME add the email sender likely your email
For the MAIL_PASSWORD you will need to create a password that is called an app password. To do that, follow this documentation:
https://docs.saleshandy.com/en/articles/10182595-how-to-set-up-an-app-password-in-google
Use the 16-digit password and paste it into the MAIL_PASSWORD without any spaces.
CAUTION! Do not share this password, and this will be in use unless you delete it. And you will not be able to view the password again once you leave the pop-up.
-Reset data database by: database/reset_database.sh from-backup
-Set database to staging: export Flask_ENV=staging
-Then: flask run

In secret_config set user to ‘heggens’ (make sure to flask run after changing usernames
-Click ‘Administration’, then click on ‘Manage Terms’
-Then within the Academic year 2026-27, enter a valid Start Date, End Date, Primary Due Date, Adjustment Due Date (The date should still be in the year that you are currently in but must be under 2026-27)

  • Then press the Term State Button (It should be green)
    -Click on ‘New Labor Status Form’
    • enter a: Supervisor, Department (cannot be the CS department), The Term (AY), the start date will automatically be populated, Lamar Gran as the student (their username is granl) a labor position that can be ranked up during adjustment (a wls 3 is appropriate), the Job type (Primary), and the hours per week must be 10.
      -press add student, Review, and then submit the form

Next:
You must approve the student form.
-in secret config change username to: granl
-Go to slack and click on link in student email and accept the form
-in secret config change username to: heggens

  • go to “pending forms”
  • Click on the labor status form you created then scroll down and click Approve
  • Click on ‘student search’ and search Lamar Gran
    You should see Lamar Gran’s Labor History.
    -click on the first form (It should be the Labor Status Form you created)
    -In the Modal click on the blue ‘Adjustment’ button
    -Change the Department and Change the position (Make it so that the WLS has increase for example to a wls 4)
    -Submit the form
    -go to slack and click on the Adjustment form email link. Within it contains the adjustment chart in which the changes to the position and wls has been made. You can also submit the form as well.
    Note: Throughout this process you can also look at the Labor History Status of the students forms to make sure it is progressing properly.

…moval of two unused weeklyhours variables, Removal of testing print statements
@RueHaile RueHaile marked this pull request as draft November 18, 2025 21:12
@ojmakinde ojmakinde linked an issue Nov 19, 2025 that may be closed by this pull request
Meatchema and others added 7 commits November 25, 2025 19:11
… into 505-student-approval-for-modified-and-adjusted-forms
…f github.com:BCStudentSoftwareDevTeam/lsf into 505-student-approval-for-modified-and-adjusted-forms
…y. The status in laborhistory is now able to change from pending to approved.
…Team/lsf into 505-student-approval-for-modified-and-adjusted-forms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Student approval for modified and adjusted forms

4 participants