This repository was archived by the owner on Oct 31, 2024. It is now read-only.
Np 45040 migrate handle to list #413
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anetteOlli
reviewed
Aug 8, 2023
| public URI getHandle() { | ||
| return handle; | ||
| public Set<URI> getHandles() { | ||
| return handles; |
Contributor
There was a problem hiding this comment.
pirk: hvis null, returner tom set.
anetteOlli
previously approved these changes
Aug 8, 2023
| public URI getHandle() { | ||
| return handle; | ||
| public Set<URI> getHandles() { | ||
| return handles; |
Contributor
|
Looking at the task, we have a small issue since the semantics here are "Handles we own" since the "handle" relates to handles we have access to and can manipulate. Maybe a distinction we should make clearer |
brinxmat
approved these changes
Aug 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.