Skip to content

Ignore JSDisconnectedExceptions during dispose #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BritBlaster wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Ignore JSDisconnectedExceptions during dispose #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f08a789
Ignore JSDisconnectedExceptions during dispose
BritBlaster Mar 17, 2024
006c4e6
Update version to 1.0.2
BritBlaster Mar 21, 2024
17826dc
Try to fix issue causing build error on appveyor
BritBlaster Mar 21, 2024
9a031d6
Remove explicit version
BritBlaster Mar 22, 2024
4b5f9c4
Update version to 1.0.4
BritBlaster Mar 22, 2024
227d749
Update Blazored.Video.csproj
BritBlaster Mar 22, 2024
80dabd1
Update Blazored.Video.csproj
BritBlaster Mar 22, 2024
305a001
Ignore TaskCanceledExceptions
BritBlaster Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions samples/BlazorWebAssembly/BlazorWebAssembly.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly" Version="6.0.0" />
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly.DevServer" Version="6.0.0" PrivateAssets="all" />
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly" Version="6.0.28" />
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly.DevServer" Version="6.0.28" />
<PackageReference Include="System.Net.Http.Json" Version="6.0.0" />
</ItemGroup>

Expand Down
6 changes: 3 additions & 3 deletions samples/SharedRCL/SharedRCL.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@


<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Components" Version="6.0.0" />
<PackageReference Include="Microsoft.AspNetCore.Components.Web" Version="6.0.0" />
<Folder Include="wwwroot\" />
</ItemGroup>


<ItemGroup>
<Folder Include="wwwroot\" />
<PackageReference Include="Microsoft.AspNetCore.Components" Version="6.0.28" />
<PackageReference Include="Microsoft.AspNetCore.Components.Web" Version="6.0.28" />
</ItemGroup>


Expand Down
12 changes: 9 additions & 3 deletions src/Blazored.Video/Blazored.Video.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk.Razor">
<Project Sdk="Microsoft.NET.Sdk.Razor">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
Expand Down Expand Up @@ -32,8 +32,14 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Components" Version="6.0.0" />
<PackageReference Include="Microsoft.AspNetCore.Components.Web" Version="6.0.0" />
<PackageReference Include="Microsoft.AspNetCore.Components" Version="6.0.28" />
<PackageReference Include="Microsoft.AspNetCore.Components.Web" Version="6.0.28" />
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly" Version="6.0.28" />
</ItemGroup>

<PropertyGroup>
<VersionPrefix>1.0.6</VersionPrefix>
<VersionSuffix></VersionSuffix>
</PropertyGroup>

</Project>
13 changes: 12 additions & 1 deletion src/Blazored.Video/BlazoredVideo.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,18 @@ protected virtual async ValueTask DisposeAsyncCore()
{
if (jsModule is not null)
{
await jsModule.DisposeAsync().ConfigureAwait(false);
try
{
await jsModule.DisposeAsync().ConfigureAwait(false);
}
catch (TaskCanceledException)
{
// ignore TaskCanceledException
}
catch (JSDisconnectedException)
{
// ignore JSDisconnectedException exceptions
}
}
}
}
Expand Down
1 change: 1 addition & 0 deletions tests/Blazored.Video.Tests/Blazored.Video.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

<ItemGroup>
<PackageReference Include="bunit" Version="1.13.5" />
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly" Version="6.0.28" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.1" />
<PackageReference Include="xunit" Version="2.4.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
Expand Down