Fix export logic: ApplicationName mismatches and CSV escaping #3292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
ApplicationNameenum values (IPNetworkInfo, SNTPLookupResultInfo, WiFiNetworkInfo)EscapeCsvValue()helper method.Replace(",", "")hacksRelated issue(s)
Based on analysis requested in PRs #3290 and #3291
Copilot generated summary
Copilot summary
ApplicationName Corrections
ApplicationName.SNMP→ApplicationName.SubnetCalculatorApplicationName.SNMP→ApplicationName.SNTPLookupApplicationName.IPScanner→ApplicationName.WiFiCSV Escaping Implementation
Added
EscapeCsvValue()helper that wraps values in quotes when they contain commas, quotes, or newlines, and escapes internal quotes by doubling them:Applied to all string fields across ConnectionInfo, DiscoveryProtocolPackageInfo, IPGeolocationInfo, TracerouteHopInfo, DNSLookupRecordInfo, HostsFileEntry, PingInfo, PortScannerInfo, OUIInfo, PortLookupInfo, IPScannerHostInfo, SNMPReceivedInfo, SNTPLookupResultInfo, NetworkInterface, and WiFiNetworkInfo export managers.
To-Do
Contributing
By submitting this pull request, I confirm the following:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.