-
Notifications
You must be signed in to change notification settings - Fork 4
Added thinSNP function #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #40 +/- ##
===============================================
- Coverage 84.87% 83.35% -1.52%
===============================================
Files 18 19 +1
Lines 1243 1358 +115
===============================================
+ Hits 1055 1132 +77
- Misses 188 226 +38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
madc2vcf exception added: presence of N
Cristianetaniguti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alex-sandercock I think you just need to roxygenise to fix the actions error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new thinSNP function for genomic data processing and makes several improvements to existing functions. The thinSNP function enables filtering SNPs based on minimum genomic distance between markers within chromosomes, which is useful for reducing linkage disequilibrium in genomic analyses.
- Added
thinSNP()function to thin SNP datasets by genomic position and minimum distance - Enhanced
updog2vcf()function to accept optional reference/alternate allele information - Updated
madc2gmat()function to support polyploid genomics with VanRaden method implementation
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| R/thinSNP.R | New function implementation for SNP thinning based on genomic coordinates |
| tests/testthat/test-thinSNP.R | Test suite for the new thinSNP function |
| man/thinSNP.Rd | Documentation for the thinSNP function |
| R/updog2vcf.R | Enhanced to support optional RefAlt parameter for actual allele information |
| R/madc2gmat.R | Major refactor to support polyploid analysis and VanRaden method |
| R/breedtools_functions.R | Exported previously internal functions for breed composition analysis |
| NAMESPACE | Updated exports and imports for new functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
man/QPsolve.Rd
Outdated
| \item{p}{numeric indicating number of breeds represented in X} | ||
|
|
||
| \item{names}{character names of breeds} |
Copilot
AI
Sep 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation includes parameters p and names that are not present in the actual function signature. The QPsolve function only accepts Y and X parameters.
| \item{p}{numeric indicating number of breeds represented in X} | |
| \item{names}{character names of breeds} |
|
|
||
| test_that("Thinning SNPs",{ | ||
|
|
||
| ##' # Create sample SNP data |
Copilot
AI
Sep 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment uses Roxygen2 syntax (##') instead of regular R comment syntax (#) in a test file. Test files should use standard R comments.
| ##' # Create sample SNP data | |
| # Create sample SNP data |
Added a thinSNP() to be able to thin a data.frame of genomic positions using a specified distance