Skip to content

BI-2539 - Add GitHub as Alternative OAuth Provider #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mlm483 merged 6 commits into from
Aug 20, 2025
Merged

BI-2539 - Add GitHub as Alternative OAuth Provider #58

mlm483 merged 6 commits into from
Aug 20, 2025

Conversation

@mlm483
Copy link
Contributor

@mlm483 mlm483 commented Jun 30, 2025 •
edited
Loading

Added VUE_APP_ALTERNATE_AUTHENTICATION_ENABLED to the biweb service definition in docker-compose.yml with a default value of false.

Also added GitHub OAuth variables to .env.template and docker-compose.yml.

# GitHub OAuth variables. Only required if using GitHub as an alternative to ORCID.
GITHUB_OAUTH_CLIENT_ID=<Client ID of GitHub OAuth app.>
GITHUB_OAUTH_CLIENT_SECRET=<Client Secret of GitHub Oauth app.>

bi-web PR: Breeding-Insight/bi-web#429
bi-api PR: Breeding-Insight/bi-api#473

@mlm483 mlm483 requested review from dmeidlin and nickpalladino June 30, 2025 14:58
@mlm483 mlm483 mentioned this pull request Jun 30, 2025
Merged
7 tasks
nickpalladino
nickpalladino requested changes Jun 30, 2025
View reviewed changes
docker-compose.yml Outdated
- SANDBOX_MODE=${SANDBOX_MODE}
- BRAPI_REFERENCE_SOURCE=${BRAPI_REFERENCE_SOURCE}
- BRAPI_VENDOR_SUBMISSION_ENABLED=${BRAPI_VENDOR_SUBMISSION_ENABLED:-false}
- VUE_APP_ALTERNATE_AUTHENTICATION_ENABLED=${VUE_APP_ALTERNATE_AUTHENTICATION_ENABLED:-false}
Copy link
Member

@nickpalladino nickpalladino Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should just be ALTERNATE_AUTHENTICATION_ENABLED without the VUE_APP_ prefix like the others.

Copy link
Contributor Author

@mlm483 mlm483 Jun 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated here and in bi-web.

mlm483
mlm483 commented Jun 30, 2025
View reviewed changes
@mlm483 mlm483 mentioned this pull request Jul 1, 2025
Merged
7 tasks
@mlm483 mlm483 merged commit b912ee0 into develop Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmeidlin dmeidlin dmeidlin approved these changes

@nickpalladino nickpalladino nickpalladino approved these changes

Assignees

@dmeidlin dmeidlin

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mlm483 @dmeidlin @nickpalladino