Skip to content

Conversation

@HMS17
Copy link
Contributor

@HMS17 HMS17 commented Aug 19, 2025

Description

Story: BI-2193 - Improve/Correct Sub-Entity Tabular View

Added logic to change columns displayed depending on whether the dataset is top-level or sub-entity dataset.
When dataset displayed is a sub-entity dataset, additional columns "Sub Unit ID" and " Obs Unit ID" are added to the display.
Exp Unit ID and Obs Unit Id columns now display correct values in sub-entity dataset view
Added alphanumeric sorting for sub-unit id
Set default sort for dataset table to Environment

Dependencies

bi-api: feature/BI-2193

Testing

When in experiment details view:

  • Create new sub-entity dataset (NOTE: this is needed for Exp Unit ID values to display for the sub-entity dataset view since placing that value in additional info for the sub-observation unit is added in this card)
  • When looking at top-level dataset check that "Sub Unit ID" is not present and only " Obs Unit ID" column is present
  • When looking at sub-entity dataset check that "Sub Unit ID" column is present and both " Obs Unit ID" and " Obs Unit ID" columns are present
  • Check that values in sub-entity view for columns "Exp Unit ID", "Sub Unit ID", " Obs Unit ID" , and " Obs Unit ID" are correct
  • Check that "Sub Unit ID" and " Obs Unit ID" columns can be sorted and sort properly

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>
  • I have run SiteImprove on pages impacted by changes

@HMS17 HMS17 marked this pull request as ready for review August 20, 2025 22:30
@HMS17 HMS17 requested review from a team, dmeidlin and mlm483 and removed request for a team August 20, 2025 22:31
@HMS17 HMS17 removed the request for review from dmeidlin August 25, 2025 17:20
@HMS17 HMS17 requested a review from nickpalladino August 25, 2025 17:21
@nickpalladino nickpalladino merged commit 32ef73d into develop Nov 25, 2025
1 check passed
@nickpalladino nickpalladino deleted the feature/BI-2193 branch November 25, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants