add point groups docs #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fennibay
reviewed
Nov 14, 2025
modeling/point-groups.md
Outdated
|
|
||
| ## Migration Notes | ||
|
|
||
| - Existing models where controllers hosted individual points should introduce Point Groups and shift the `brick:hosts` relationship to target the group. Equipment such as VAV boxes can continue to reference their points through `brick:hasPoint`. |
There was a problem hiding this comment.
Since brick:hosts wasn't merged yet, I think we can remove this point.
|
Looks good for me, just have a minor comment. Thank you @gtfierro! |
Clarify the role of Point Groups in modeling and emphasize their relationship with `brick:hasPoint`.
fennibay
reviewed
Nov 14, 2025
| Avoid inferring semantics from group membership alone. For example, adding a setpoint and its min/max limits to the same Point Group does *not* mean those limits constrain that setpoint. Model explicit relationships if you need to express functional ties. | ||
| ``` | ||
|
|
||
| This is *not* a replacement for `brick:hasPoint`! You should still use `brick:hasPoint`/`brick:isPointOf` to relate points to their equipment. This modeling construct focuses on the networking/instrumentation of the system. |
There was a problem hiding this comment.
Would it help to give a few examples?
- a
VAVcould have aSupply_Air_Flow_Sensor, but this point is hosted by aController - a
Controllercould have anOn_Off_Status, which is hosted also on the sameController
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.