Add pre-commit config and workflow #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `is` operator checks for identity, not equality. To check for an empty
list, one should use either:
if roles == []:
Or just take advantage of the fact that an empty list is `False` when used
in a boolean expression, and write:
if not roles:
This commit takes the second option.
Bring this repository in line with other ESI repositories and introduce our standard linting and ruff-based formatting of Python code.
Correct all the errors reported by pre-commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring this repository in line with other ESI repositories and introduce our
standard linting and ruff-based formatting of Python code.
NB: This PR is based on #66